fix: --export-scp hang bug#524
Open
sadsfae wants to merge 4 commits intoredhat-performance:developmentfrom
Open
fix: --export-scp hang bug#524sadsfae wants to merge 4 commits intoredhat-performance:developmentfrom
sadsfae wants to merge 4 commits intoredhat-performance:developmentfrom
Conversation
* export_scp method polling loop 'continue' statement was nested inside an unnecessary 'else:' block after the timeout check. This made the control flow inconsistent with the working import_scp() method. fixes: redhat-performance#499
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## development #524 +/- ##
===============================================
+ Coverage 92.24% 92.28% +0.03%
===============================================
Files 8 8
Lines 2516 2515 -1
===============================================
Hits 2321 2321
+ Misses 195 194 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes: #499