[WIP] Video plugin improvements - #32
Conversation
|
Do not merge. I doesn't work. |
|
Is it ready for merge? |
|
I do not have HW to test :) |
|
I don't know, I can't test it either. Let's wait for Oliver. |
oliverhenshaw
left a comment
oliverhenshaw
left a comment
There was a problem hiding this comment.
This look generally right to me - thanks.
A couple of niggles though - adding "radeon_dpm_state=balanced" is not enough to avoid complaints in tuned.log and from "tuned-adm verify". I need to add "radeon_powersave=dpm" too.
Secondly, "tuned-adm verify" doesn't seem to do anything to check radeon_dpm_state - I tried setting it to a nonsense value and although I got an error when changing profile I didn't see any complaints when I ran the verify subcommand.
| elif value == "dpm": | ||
| if not sim and self._get_radeon_powersave(device) != "dpm": | ||
| log.error("Cannot set dpm power method through the video plugin." \ | ||
| + "Use the sysctl plugin with the 'radeon.dpm=1' option") |
There was a problem hiding this comment.
I don't think this is strictly correct. The radeon.dpm option is a boot-time parameter, not one that can be changed with sysctl.
There was a problem hiding this comment.
Thanks, I guess I meant to say the bootloader plugin.
Support changing the 'power_dpm_state' parameter of Radeon GPUs. It only works if the 'dpm' power method is enabled. Note that the 'dpm' power method cannot be enabled through the video plugin, but it can be set using the bootloader plugin using 'cmdline = radeon.dpm=1'. The video plugin now recognizes a new 'radeon_dpm_state' option which changes the dpm state. Possible values are 'battery', 'balanced' and 'performance' [1]. [video] radeon_dpm_state=balanced [1] https://wiki.archlinux.org/index.php/ATI#Dynamic_power_management Resolves: rhbz#1417659 Signed-off-by: Ondřej Lysoněk <olysonek@redhat.com>
I don't understand. What exactly are you seeing in the log? Adding "radeon_powersave=dpm" should actually cause an error message.
The verify command seems to behave badly in some cases when setting nonsensical values. The same happens in the CPU plugin with governor for example. We'll have to deal with that later in some more generic way. But I think the verify command should now correctly detect that the current value is different from a legal value in the tuned profile. |
|
Thanks, LGTM, I will also probably update the profiles to use the DPM by default. |
Now, in addition to the already supported Radeon power methods, it also supports: radeon_powersave=DPM where DPM can be 'battery', 'balanced', or 'performance'. It also supports fallback, so one can write: radeon_powersave=balanced, auto where it tries 'balanced' DPM profile and if it fails or is not supported it fallbacks to the non DPM 'auto' profile. As delimiters colon, semilocon, comma or whitespace can be used. It also switched upstream profiles to prefer DPM. #32 Related: rhbz#1417659 Signed-off-by: Jaroslav Škarvada <jskarvad@redhat.com>
|
I rewrote it a bit in eef09f1. Unfortunately I do not have compatible video card, so I wasn't able to test it. |
3 participants
Support the 'dpm' power method on Radeon GPUs. Implement automatic selection of the best power method and use it in the balanced profile.
Resolves: rhbz#1417659