RI-000: fix e2e workflows #5277
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArtemHoruzhenko
requested review from
DimoHG,
KrumTy,
dantovska,
pawelangelow,
pd-redis,
tptodorov and
valkirilov
as code owners
KrumTy
previously approved these changes
Dec 1, 2025
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| uses: ./.github/workflows/tests-e2e-docker-smoke.yml | ||
| secrets: inherit | ||
| with: | ||
| debug: ${{ inputs.debug || false }} |
There was a problem hiding this comment.
Bug: Undefined inputs.debug referenced in push-triggered workflows
The workflows reference inputs.debug but are only triggered by push events without any inputs definition. Unlike tests-e2e.yml which has a workflow_dispatch trigger with debug input defined, these release workflows have no way to receive this input. The expression ${{ inputs.debug || false }} will always evaluate to false, making the debug parameter effectively dead code and preventing SSH debugging from ever being enabled in these workflows.
Additional Locations (1)
KrumTy
approved these changes
Dec 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Testing
Note
Split E2E Docker tests into smoke, critical path, and regression jobs for prod and stage releases, updating workflow references, inputs, and downstream dependencies.
e2e-docker-testsjob with three jobs:e2e-docker-tests-smoke,e2e-docker-tests-critical-path,e2e-docker-tests-regression.tests-e2e-docker-smoke.yml,tests-e2e-docker-critical-path.yml,tests-e2e-docker-regression.yml.with: debug: ${{ inputs.debug || false }}to each E2E job.remove-artifacts.needsto depend on the three new E2E jobs (plus existing AppImage tests and AWS upload where applicable).Written by Cursor Bugbot for commit 9d9f9a4. This will update automatically on new commits. Configure here.