Skip to content

RI-000: fix e2e workflows #5277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 1, 2025
Merged

RI-000: fix e2e workflows #5277

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2947cb8
RI-000: fix e2e workflows
ArtemHoruzhenko Dec 1, 2025
9d9f9a4
RI-000: fix e2e workflows + eslint
ArtemHoruzhenko Dec 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 33 additions & 8 deletions .github/workflows/release-prod.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,15 +3,15 @@ name: ❗ Release (prod)
on:
push:
branches:
- 'latest'
- "latest"

jobs:
tests-prod:
name: Run all tests
uses: ./.github/workflows/tests.yml
secrets: inherit
with:
group_tests: 'without_e2e'
group_tests: "without_e2e"
short_rte_list: false
pre_release: true

Expand All @@ -21,14 +21,32 @@ jobs:
needs: tests-prod
secrets: inherit
with:
environment: 'production'
target: 'all'
environment: "production"
target: "all"

e2e-docker-tests:
name: E2E Docker tests
e2e-docker-tests-smoke:
name: "E2E: Smoke (Docker)"
needs: builds-prod
uses: ./.github/workflows/tests-e2e-docker.yml
uses: ./.github/workflows/tests-e2e-docker-smoke.yml
secrets: inherit
with:
debug: ${{ inputs.debug || false }}
Copy link

@cursor cursor bot Dec 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Undefined inputs.debug referenced in push-triggered workflows

The workflows reference inputs.debug but are only triggered by push events without any inputs definition. Unlike tests-e2e.yml which has a workflow_dispatch trigger with debug input defined, these release workflows have no way to receive this input. The expression ${{ inputs.debug || false }} will always evaluate to false, making the debug parameter effectively dead code and preventing SSH debugging from ever being enabled in these workflows.

Additional Locations (1)

Fix in Cursor Fix in Web


e2e-docker-tests-critical-path:
name: "E2E: Critical Path (Docker)"
needs: builds-prod
uses: ./.github/workflows/tests-e2e-docker-critical-path.yml
secrets: inherit
with:
debug: ${{ inputs.debug || false }}

e2e-docker-tests-regression:
name: "E2E: Regression (Docker)"
needs: builds-prod
uses: ./.github/workflows/tests-e2e-docker-regression.yml
secrets: inherit
with:
debug: ${{ inputs.debug || false }}

e2e-appimage-tests:
name: E2E AppImage tests
Expand Down Expand Up @@ -60,7 +78,14 @@ jobs:
# Remove artifacts from github actions
remove-artifacts:
name: Remove artifacts
needs: [aws-upload-prod, e2e-docker-tests, e2e-appimage-tests]
needs:
[
aws-upload-prod,
e2e-docker-tests-smoke,
e2e-docker-tests-critical-path,
e2e-docker-tests-regression,
e2e-appimage-tests,
]
if: always()
runs-on: ubuntu-latest

Expand Down
38 changes: 32 additions & 6 deletions .github/workflows/release-stage.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ name: 📖 Release (stage)
on:
push:
branches:
- 'release/**'
- "release/**"

jobs:
tests:
Expand All @@ -20,8 +20,8 @@ jobs:
needs: tests
secrets: inherit
with:
environment: 'staging'
target: 'all'
environment: "staging"
target: "all"

aws:
uses: ./.github/workflows/aws-upload-dev.yml
Expand All @@ -31,10 +31,29 @@ jobs:
with:
pre-release: true

e2e-docker-tests:
e2e-docker-tests-smoke:
name: "E2E: Smoke (Docker)"
needs: builds
uses: ./.github/workflows/tests-e2e-docker.yml
uses: ./.github/workflows/tests-e2e-docker-smoke.yml
secrets: inherit
with:
debug: ${{ inputs.debug || false }}

e2e-docker-tests-critical-path:
name: "E2E: Critical Path (Docker)"
needs: builds
uses: ./.github/workflows/tests-e2e-docker-critical-path.yml
secrets: inherit
with:
debug: ${{ inputs.debug || false }}

e2e-docker-tests-regression:
name: "E2E: Regression (Docker)"
needs: builds
uses: ./.github/workflows/tests-e2e-docker-regression.yml
secrets: inherit
with:
debug: ${{ inputs.debug || false }}

e2e-appimage-tests:
needs: builds
Expand All @@ -44,7 +63,14 @@ jobs:
# Remove artifacts from github actions
remove-artifacts:
name: Remove artifacts
needs: [aws, e2e-docker-tests, e2e-appimage-tests]
needs:
[
aws,
e2e-docker-tests-smoke,
e2e-docker-tests-critical-path,
e2e-docker-tests-regression,
e2e-appimage-tests,
]
if: always()
runs-on: ubuntu-latest

Expand Down
Loading