RI-8276 i18n: migrate Cluster Details analytics page#6198
Merged
valkirilov merged 1 commit intoJul 14, 2026
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 39096b4dd3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Route the Cluster Details page through i18n under analytics.clusterDetails.* with Bulgarian translations: page title, node table headers (primary-nodes count via i18next plurals) + empty state, donut chart titles, and header metrics. Column headers resolve at render via i18n.t() functions in the config; a stable `id` on each header metric keeps React keys/test ids independent of the translated label. Extends the shared analytics.units.* group (B/kb/s/%/s) resolved through t() so those units localize to Bulgarian. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
39096b4 to
50cfecc
Compare
Contributor
Code Coverage - Frontend unit tests
Test suite run success7763 tests passing in 860 suites. Report generated by 🧪jest coverage report action from 50cfecc |
dantovska
approved these changes
Jul 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Routes the Cluster Details analytics page through i18next under
analytics.clusterDetails.*(+ sharedanalytics.units.*), with Bulgarian translations. Text-only; no behavior change.Note
Low Risk
Text-only localization on an analytics page; test IDs were adjusted to use stable IDs instead of translated labels.
Overview
Internationalizes the Cluster Details analytics screen by replacing hardcoded English strings with i18next keys under
analytics.clusterDetails.*and sharedanalytics.units.*, including Bulgarian entries inbg.json.The page title, header metric labels, donut chart titles, table column headers (with pluralized primary-node count), empty state copy, and unit suffixes (
kb/s,B,%) now resolve throughuseTranslationor thei18nsingleton in table constants/formatters. ClusterDetailsHeader adds stable metricidvalues for React keys anddata-testids so they stay English regardless of locale; uptime’s" s"suffix in the tooltip remains literal per an inline comment.Reviewed by Cursor Bugbot for commit 50cfecc. Bugbot is set up for automated code reviews on this repo. Configure here.