Skip to content

feat(i18n): migrate browser advanced value editors to i18n (RI-8274) - #6290

Merged
valkirilov merged 8 commits into
feature/RI-8274-i18n-simple-value-editorsfrom
feature/RI-8274-i18n-advanced-value-editors
Jul 30, 2026
Merged

feat(i18n): migrate browser advanced value editors to i18n (RI-8274)#6290
valkirilov merged 8 commits into
feature/RI-8274-i18n-simple-value-editorsfrom
feature/RI-8274-i18n-advanced-value-editors

Conversation

@valkirilov

@valkirilov valkirilov commented Jul 24, 2026

Copy link
Copy Markdown
Member

Summary

Routes all user-facing strings in the array, stream and vector-set value editors through t() with flat browser.<type>.* keys, filled in both en.json and bg.json (Bulgarian).

Commits (one per type)

  1. array-details (~63 keys) - the vector-set array viewer: View/Search/Aggregate tab labels, add/range/search/aggregate forms (labels, hints, placeholders, invalid/too-large messages, Run/Reset), table columns + empty/loading states, Context control, value-editor drawer, bulk actions. Translated the AND/OR connective labels; kept command flags/mode tokens (NOCASE/SUM/Exact/-/+) literal.
  2. stream-details (~54 keys) - Stream Data / Consumer Groups tabs, STREAM_ADD_ACTION new-entry/group, data/consumers/messages/groups tables (columns, empty-states, <Trans> delete messages), add-entry & add-group panels (shared ID tooltip/hint/error), ACK / CLAIM popovers (all labels, getConsumersOptions/getTimeOptionst-factories). Kept ACK/CLAIM/msec literal.
  3. vector-set-details (~58 keys) - element list + similarity results tables, element-details drawer, element form (incl. getVectorFieldInfo vector-validation messages via t), attribute editor warning, similarity search form (modes/placeholders/tooltips), filter-syntax help popover, subheader. Kept filter code examples / monaco options literal.

Note

Low Risk
Presentation-only i18n wiring across browser value editors; Redis write paths and validation rules are unchanged. Only English and Bulgarian locale files were extended, so other locales may fall back until keys are added elsewhere.

Overview
Replaces hardcoded UI copy in the array, stream, and vector-set key-detail flows with useTranslation() / t(), backed by new browser.array.*, browser.stream.*, and browser.vectorSet.* entries in en.json and bg.json.

Constants and labels that used to be literal English strings now store ParseKeys (tab labels, form hints, table empty/loading text, production-write confirmations, ARIA labels). STREAM_ADD_ACTION likewise stores i18n keys resolved when rendering the add action. Stream delete copy uses <Trans> for interpolated messages; similarity tables localize column headers at build/render time via helpers that accept t.

Specs assert translated text through i18n.t(...) where labels are no longer raw strings. Redis/command tokens (e.g. NOCASE, ACK, filter examples) stay literal where noted in the PR.

Reviewed by Cursor Bugbot for commit 733e05d. Bugbot is set up for automated code reviews on this repo. Configure here.

@valkirilov
valkirilov requested a review from a team as a code owner July 24, 2026 13:02
@valkirilov valkirilov self-assigned this Jul 24, 2026

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8a8522c5e9

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7f19572159

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@valkirilov
valkirilov force-pushed the feature/RI-8274-i18n-advanced-value-editors branch from c1e64bc to 80a1c78 Compare July 24, 2026 13:55

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ba0f692a00

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@github-actions

github-actions Bot commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Code Coverage - Frontend unit tests

St.
Category Percentage Covered / Total
🟢 Statements 83.5% 28642/34300
🟡 Branches 69.58% 12192/17523
🟡 Functions 78.54% 7570/9638
🟢 Lines 83.97% 27846/33163

Test suite run success

7979 tests passing in 869 suites.

Report generated by 🧪jest coverage report action from 733e05d

dantovska
dantovska previously approved these changes Jul 27, 2026
@valkirilov
valkirilov force-pushed the feature/RI-8274-i18n-advanced-value-editors branch from ba0f692 to 701e128 Compare July 27, 2026 13:49
@valkirilov
valkirilov force-pushed the feature/RI-8274-i18n-advanced-value-editors branch from 701e128 to 8dcf6ec Compare July 28, 2026 11:55
@valkirilov
valkirilov force-pushed the feature/RI-8274-i18n-advanced-value-editors branch from 8dcf6ec to 696d154 Compare July 29, 2026 06:26
@valkirilov
valkirilov force-pushed the feature/RI-8274-i18n-advanced-value-editors branch from 696d154 to 7e57da5 Compare July 30, 2026 05:59

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 7e57da5. Configure here.

@valkirilov
valkirilov disabled the stack merge July 30, 2026 07:00
@valkirilov
valkirilov disabled the stack merge July 30, 2026 07:50
@valkirilov
valkirilov force-pushed the feature/RI-8274-i18n-advanced-value-editors branch from 7e57da5 to 733e05d Compare July 30, 2026 08:25
@valkirilov
valkirilov disabled the stack merge July 30, 2026 08:44
@valkirilov
valkirilov disabled the stack merge July 30, 2026 09:04
@valkirilov
valkirilov disabled the stack merge July 30, 2026 09:33
@valkirilov
valkirilov disabled the stack merge July 30, 2026 09:35
@valkirilov
valkirilov disabled the stack merge July 30, 2026 10:20
@valkirilov
valkirilov merged commit e825f16 into main Jul 30, 2026
32 of 36 checks passed
@valkirilov
valkirilov deleted the feature/RI-8274-i18n-advanced-value-editors branch July 30, 2026 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants