Promote Array & Vector Set key types on unsupported Redis versions - #6302
Merged
Conversation
dantovska
force-pushed
the
fe/feature/promote-version-gated-key-types
branch
from
July 28, 2026 13:06
7863ff4 to
3feb9ce
Compare
…dis versions
On Redis versions that don't support Array (8.8+) or Vector Set (8.0+), the Add
Key type dropdown now keeps these options visible but greyed-out (disabled) with
a highlighted lock icon on the right; hovering the lock shows a tooltip
("Requires Redis x.y+") — nudging users to upgrade instead of silently hiding
the types. Feature-flag gating still hides options entirely, so an unreleased
type is never shown as a disabled teaser. Disabled options are guarded against
selection.
Option rendering is extracted into a KeyTypeOption component (styles/constants/
tests colocated), and a RiHighlightedIcon wrapper is added around the @redis-ui
HighlightedIcon.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
dantovska
force-pushed
the
fe/feature/promote-version-gated-key-types
branch
from
July 28, 2026 13:15
3feb9ce to
ddc69fc
Compare
KrumTy
approved these changes
Jul 28, 2026
valkirilov
approved these changes
Jul 28, 2026
pawelangelow
approved these changes
Jul 28, 2026
Contributor
Code Coverage - Frontend unit tests
Test suite run success7913 tests passing in 872 suites. Report generated by 🧪jest coverage report action from ddc69fc |
dantovska
added a commit
that referenced
this pull request
Jul 28, 2026
… types The Add Key type dropdown now shows Array/Vector Set as disabled (with a lock icon and version tooltip) on unsupported Redis versions instead of hiding them. Update the Vector Set gating spec to assert the shown-but-disabled state on Redis < 8.0 and the enabled state on 8.8.0. Depends on the UI change in PR #6302 — merge after it. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Promote the Array (Redis 8.8+) and Vector Set (Redis 8.0+) key types on databases that don't support them yet.
Previously these types were hidden from the Add Key type dropdown on unsupported Redis versions. Now they stay visible but greyed-out (disabled), with a highlighted lock icon on the right and a tooltip "Requires Redis x.y+" on hover — nudging users to upgrade rather than silently hiding the feature.
KeyTypeOptioncomponent (styles/constants/tests); aRiHighlightedIconinternal wrapper is added around the@redis-uiHighlightedIcon.UI-only; no API or data changes.
Testing
AddKey.spec.tsx,KeyTypeOption.spec.tsx.Note
Low Risk
UI-only change to Add Key dropdown rendering and selection guards; no API or data path changes.
Overview
Add Key no longer hides Redis version–gated types (e.g. Vector Set, Array) when the connected instance is too old. They stay in the key-type dropdown as disabled rows so users see the feature exists but cannot select it.
Unsupported options use a new
KeyTypeOptionrow: colored label plus a lockRiHighlightedIconwith tooltipbrowser.addKey.requiresVersion(“Requires Redis {{version}}+”).AddKeymaps all enabled options withdisabled+inputDisplay, blocksonChangeTypefor disabled values, and drops the old filter that removed low-version types. Feature-flag–gated types are unchanged (still omitted, not teased).Adds
RiHighlightedIconre-export, en/bg i18n, and unit tests forAddKey/KeyTypeOption.Reviewed by Cursor Bugbot for commit ddc69fc. Bugbot is set up for automated code reviews on this repo. Configure here.