docs(contributing): document Docker Desktop host networking requireme… - #3330
Merged
nkaradzhov merged 1 commit intoJul 10, 2026
Merged
Conversation
…nt for tests on macOS/Windows The test suite spawns Redis containers with --network host, which only works out of the box on Linux. Docker Desktop 4.34+ supports host networking on macOS and Windows behind an opt-in setting; with it enabled the full suite (including cluster tests) runs unchanged. Fixes redis#2358 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
PavelPashov
approved these changes
Jul 10, 2026
Merged
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test suite spawns Redis containers with --network host, which only works out of the box on Linux. Docker Desktop 4.34+ supports host networking on macOS and Windows behind an opt-in setting; with it enabled the full suite (including cluster tests) runs unchanged.
Fixes #2358
Description
Checklist
npm testpass with this change (including linting)?Note
Low Risk
Documentation-only change with no runtime or API impact.
Overview
Adds a Running the tests on macOS and Windows subsection under Testing Code in
CONTRIBUTING.md.It documents that the suite uses Redis containers with
--network host, which on macOS and Windows requires Docker Desktop 4.34+ with Settings → Resources → Network → Enable host networking. Without that, dockerized tests may hang or time out because containers are not reachable from the host.Reviewed by Cursor Bugbot for commit 2f59f86. Bugbot is set up for automated code reviews on this repo. Configure here.