Fix #2581 UnixDomainSocketConnection' object has no attribute '_command_packer' #2583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…command_packer' . Apparently there is no end-to-end tests for Unix sockets so automation didn't catch it. I assume that setting up domain sockets reliably in dockerized environment is not very trivial. Added test for pack_command specifically.
Locally: " congratulations :)"
hiredis doesn't treat memoryviews differently.
Codecov ReportBase: 92.28% // Head: 92.27% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #2583 +/- ##
==========================================
- Coverage 92.28% 92.27% -0.02%
==========================================
Files 115 115
Lines 29736 29744 +8
==========================================
+ Hits 27442 27446 +4
- Misses 2294 2298 +4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
|
dvora-h
approved these changes
Feb 8, 2023
|
I can confirm this fixes the issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Pull Request check-list
Please make sure to review and check all of these items:
$ toxpass with this change (including linting)?NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.
Description of change
Apparently there is no end-to-end tests for Unix sockets
so automation didn't catch it. I assume that setting up
the domain sockets reliably in dockerized/tox environment is not that easy.
Added test for pack_command specifically.