Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for lpop and rpop return typing #2590

Merged
merged 1 commit into from Feb 15, 2023
Merged

Fix for lpop and rpop return typing #2590

merged 1 commit into from Feb 15, 2023

Conversation

Galtozzy
Copy link
Contributor

Right now there is an annoying warning that these methods can't be awaited when using redis.asyncio, even tho it does work with no problems.

Description of change

Very minor change.
Fixed type annotation for lpop and rpop methods.

@codecov-commenter
Copy link

codecov-commenter commented Feb 13, 2023

Codecov Report

Base: 92.29% // Head: 92.27% // Decreases project coverage by -0.03% ⚠️

Coverage data is based on head (5c121df) compared to base (fd7a79d).
Patch coverage: 100.00% of modified lines in pull request are covered.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2590      +/-   ##
==========================================
- Coverage   92.29%   92.27%   -0.03%     
==========================================
  Files         115      115              
  Lines       29744    29744              
==========================================
- Hits        27453    27446       -7     
- Misses       2291     2298       +7     
Impacted Files Coverage Δ
redis/commands/core.py 82.15% <100.00%> (ø)
tests/test_cluster.py 96.64% <0.00%> (-0.33%) ⬇️
tests/test_asyncio/test_pubsub.py 99.37% <0.00%> (-0.16%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Right now there is an annoying warning that these methods can't be awaited when using `redis.asyncio`, even tho it does work with no problems.
@dvora-h dvora-h added the maintenance Maintenance (CI, Releases, etc) label Feb 14, 2023
@dvora-h dvora-h merged commit e9ad2a3 into redis:master Feb 15, 2023
40 checks passed
@Galtozzy Galtozzy deleted the patch-1 branch February 15, 2023 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Maintenance (CI, Releases, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants