Apply routing and response aggregation policies in OSS Cluster mode #3834
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added poilcy resolution method * Moved main command proceessing on top * Fixed return type and keyless detection * Added Dynamic and Static policies * Added coverage for policy resolvers * Removed all policies except search (phase 1) * Applied comments
* Added poilcy resolution method * Moved main command proceessing on top * Fixed return type and keyless detection * Added Dynamic and Static policies * Added coverage for policy resolvers * Applied request policies * Removed all policies except search (phase 1) * Policy applied for normal and pipeline mode * Added assertion with core command * Applied comments * Renamed method
* Added poilcy resolution method * Moved main command proceessing on top * Fixed return type and keyless detection * Added Dynamic and Static policies * Added coverage for policy resolvers * Applied request policies * Removed all policies except search (phase 1) * Policy applied for normal and pipeline mode * Added assertion with core command * Applied comments * Added async support for Request/Responce policies * Fixed method name * Updated async to sync
…response-policies
…is-py into feat/request-response-policies
…is-py into feat/request-response-policies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
Please make sure to review and check all of these items:
NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.
Description of change
This PR introduces new routing and response aggregation policies for commands. Existing policies was mapped to new one to keep backward-compatibility. Keyless commands now will be randomly distributed across shards for better load balancing.
By default static policies applied for search commands and override one provided by COMMAND. Dynamic policy resolver implementation is added and might be applicable if COMMAND tips wants to be respected