-
Notifications
You must be signed in to change notification settings - Fork 4
DOC-241 doc all possible cluster states #323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for rp-cloud ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the 📝 WalkthroughWalkthroughA new documentation page, "Cluster State," has been added under the "Cluster Maintenance" section in the navigation structure. This page details the various possible states of a cluster managed by Redpanda Cloud, categorizing them by deployment type: Serverless, BYOC (Bring Your Own Cloud), and Dedicated. Each deployment type has a tabbed table listing all possible states and their descriptions. No changes were made to code, APIs, or existing documentation outside of these additions. Sequence Diagram(s)Assessment against linked issues
Assessment against linked issues: Out-of-scope changesNo out-of-scope changes were found. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 3
🧹 Nitpick comments (1)
modules/manage/pages/cluster-maintenance/cluster-state.adoc (1)
21-21: Inconsistent state naming across tables
Serverless usesUnrecognizedandUnspecified, while BYOC and Dedicated useUnknown. Consider unifying state terms or explaining why different terminology is used.Also applies to: 41-41, 60-60
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
modules/ROOT/nav.adoc(1 hunks)modules/manage/pages/cluster-maintenance/cluster-state.adoc(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: Redirect rules - rp-cloud
- GitHub Check: Header rules - rp-cloud
- GitHub Check: Pages changed - rp-cloud
🔇 Additional comments (1)
modules/ROOT/nav.adoc (1)
385-385: Navigation entry added under Cluster Maintenance looks correct
The newcluster-state.adoclink follows the existing pattern and indentation.
|
@birdayz Would you please review and confirm that we should document these cluster states? Do users need to know how transitions between cluster states happen? |
| |Failed |Cluster was unable to enter the ready state from either the creating or placing states. | ||
| |Placing |Cluster is in the process of being placed on a cell with sufficient resources in the data plane. | ||
| |Ready |Cluster is running and accepting external requests. | ||
| |Suspended |Cluster is running but blocks all external requests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we mention suspension is mostly related to being out of credits keep me true on the suspension reason @nicolaferraro.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
True, automated suspension (close to 100% of the cases) is related to credit exhaustion for trial accounts. Adding a credit card unlocks clusters that transition to the Ready state again.
| [cols="1,4",options="header"] | ||
| |=== | ||
| |State |Description | ||
| |Creating |Cluster is in the process of having its control plane state created. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not a native speaker but this reads a little off imo, could we simply say The Redpanda cluster has started the creation process
This comment was marked as resolved.
This comment was marked as resolved.
Co-authored-by: Santiago Jimenez Giraldo <santiago@redpanda.com>
Correct it is Upgrading, the public states are: |
sago2k8
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments on the states, sorry for taking long to review.
| |Deleting agent |Cluster is in the process of having its control plane state removed, and the Redpanda Cloud agent is being removed. | ||
| |Upgrading |Cluster is undergoing a rolling upgrade or a scale-up/scale-down operation. | ||
| |Failed |Cluster was unable to enter the Ready state from either the Creating or the Creating agent states. | ||
| |Suspended |Cluster is running but blocks all external requests. + |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes it's possible to be in suspended state.
c4milo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me as initial documentation about cluster states but I'm honestly not super happy of how we designed this state machine, and customers will also notice.
|
@sago2k8, or any reviewer: What action can a user take to get out of a failed state? |
Today, re-creating the cluster, there will be some details about what went wrong. |
| |Placing |Cluster is in the process of being placed on a cell with sufficient resources in the data plane. | ||
| |Ready |Cluster is running and accepting external requests. | ||
| |Deleting |Cluster is in the process of having its control plane state removed. Resources dedicated to the cluster in the data plane will be released. | ||
| |Failed |Cluster was unable to enter the ready state from either the Creating or Placing states. + |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
where can I check what went wrong? If we know, we could provide this info here
| |State |Description | ||
| |Creating |Cluster is in the process of having its control plane state created. | ||
| |Placing |Cluster is in the process of being placed on a cell with sufficient resources in the data plane. | ||
| |Ready |Cluster is running and accepting external requests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do we mean exactly by external requests? Requests outside of the network?
Maybe a better question is, what is an internal request?
| |Deleting |Cluster is in the process of having its control plane state removed. Resources dedicated to the cluster in the data plane are released. | ||
| |Deleting agent |Cluster is in the process of having its control plane state removed, and the Redpanda Cloud agent is being removed. | ||
| |Upgrading |Cluster is undergoing a rolling upgrade or a scale-up/scale-down operation. | ||
| |Failed |Cluster was unable to enter the Ready state from either the Creating or the Creating agent states. + |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| |Failed |Cluster was unable to enter the Ready state from either the Creating or the Creating agent states. + | |
| |Failed |Cluster was unable to enter the *Ready* state from either the *Creating* or the *Creating agent states*. + |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and again, if we know where the user can look, we should provide directions
Co-authored-by: Paulo Borges <paulohtb6@gmail.com>
Co-authored-by: Paulo Borges <paulohtb6@gmail.com>
Description
This pull request introduces a new section to the documentation about cluster states, providing descriptions of various states for different cluster types (Serverless, BYOC, and Dedicated).
Documentation updates:
Added a new "Cluster State" page: This page explains the various states a cluster can be in, categorized by cluster types (Serverless, BYOC, Dedicated). It includes detailed descriptions of each state, such as "Creating," "Ready," "Suspended," and more.
Updated navigation to include the "Cluster State" page: Added a new entry under the "Cluster Maintenance" section in the navigation (
modules/ROOT/nav.adoc).Resolves https://redpandadata.atlassian.net/browse/DOC-241
Review deadline:
Page previews
Cluster State
Checks