preview: Remove token structure examples from Cloud GBAC docs#553
preview: Remove token structure examples from Cloud GBAC docs#553
Conversation
Temporarily override the docs repo branch to fix/remove-token-examples-from-cloud-gbac so the Netlify deploy preview shows the Cloud GBAC pages without the token structure examples section.⚠️ Revert before merge. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
✅ Deploy Preview for rp-cloud ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
📝 WalkthroughWalkthroughThis pull request updates the Antora playbook configuration file to change the branch used for pulling documentation content from the redpanda-data/documentation repository. The Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@local-antora-playbook.yml`:
- Line 18: The playbook's branches array currently contains a preview-only
feature branch in the "branches" entry (branches:
[fix/remove-token-examples-from-cloud-gbac, v/*, shared, site-search]) which
triggers the CI policy failure; update the "branches" configuration to point
back to the canonical branch (e.g., replace the feature branch entry with main)
or move this preview override into a CI-excluded playbook file, and ensure the
preview-only override is reverted to main before merging so the `Check playbook
branches` policy no longer fails.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: d7634625-cdc6-42eb-8b65-95c253a34231
📒 Files selected for processing (1)
local-antora-playbook.yml
| branches: HEAD | ||
| - url: https://github.com/redpanda-data/documentation | ||
| branches: [main, v/*, shared, site-search] | ||
| branches: [fix/remove-token-examples-from-cloud-gbac, v/*, shared, site-search] |
There was a problem hiding this comment.
Preview branch override currently breaks required CI policy.
Line 18 intentionally points to a feature branch for preview, but this triggers the Check playbook branches failure (Non-standard branch reference found) and leaves the PR non-mergeable. Keep this for preview-only validation, then revert to main before merge (or close the PR after review), or move preview-only overrides to a CI-excluded playbook file.
Suggested revert before merge
- branches: [fix/remove-token-examples-from-cloud-gbac, v/*, shared, site-search]
+ branches: [main, v/*, shared, site-search]Based on learnings: this cross-repo preview override pattern is expected, and the playbook is reverted to main before merging.
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| branches: [fix/remove-token-examples-from-cloud-gbac, v/*, shared, site-search] | |
| branches: [main, v/*, shared, site-search] |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@local-antora-playbook.yml` at line 18, The playbook's branches array
currently contains a preview-only feature branch in the "branches" entry
(branches: [fix/remove-token-examples-from-cloud-gbac, v/*, shared,
site-search]) which triggers the CI policy failure; update the "branches"
configuration to point back to the canonical branch (e.g., replace the feature
branch entry with main) or move this preview override into a CI-excluded
playbook file, and ensure the preview-only override is reverted to main before
merging so the `Check playbook branches` policy no longer fails.
|
closing as this was only necessary for preview in docs |
1 participant
Summary
fix/remove-token-examples-from-cloud-gbacbranch in the docs repo to generate a Cloud deploy previewPreview pages
Self-managed preview (from docs#1669 — unchanged)
🤖 Generated with Claude Code