Skip to content

preview: Remove token structure examples from Cloud GBAC docs #553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
micheleRP wants to merge 1 commit into from
+1 −1
Closed

preview: Remove token structure examples from Cloud GBAC docs #553

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion local-antora-playbook.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ content:
- url: .
branches: HEAD
- url: https://github.com/redpanda-data/documentation
branches: [main, v/*, shared, site-search]
branches: [fix/remove-token-examples-from-cloud-gbac, v/*, shared, site-search]
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot Apr 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

Preview branch override currently breaks required CI policy.

Line 18 intentionally points to a feature branch for preview, but this triggers the Check playbook branches failure (Non-standard branch reference found) and leaves the PR non-mergeable. Keep this for preview-only validation, then revert to main before merge (or close the PR after review), or move preview-only overrides to a CI-excluded playbook file.

Suggested revert before merge 
-    branches: [fix/remove-token-examples-from-cloud-gbac, v/*, shared, site-search]
+    branches: [main, v/*, shared, site-search]

Based on learnings: this cross-repo preview override pattern is expected, and the playbook is reverted to main before merging.

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
branches: [fix/remove-token-examples-from-cloud-gbac, v/*, shared, site-search]
branches: [main, v/*, shared, site-search]
🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In `@local-antora-playbook.yml` at line 18, The playbook's branches array
currently contains a preview-only feature branch in the "branches" entry
(branches: [fix/remove-token-examples-from-cloud-gbac, v/*, shared,
site-search]) which triggers the CI policy failure; update the "branches"
configuration to point back to the canonical branch (e.g., replace the feature
branch entry with main) or move this preview override into a CI-excluded
playbook file, and ensure the preview-only override is reverted to main before
merging so the `Check playbook branches` policy no longer fails.

- url: https://github.com/redpanda-data/docs-site
branches: [main]
start_paths: [home]
Expand Down
Loading