oracledb_cdc: handle row id based predicates#4585
Merged
Merged
Conversation
Replace the blind scan with a peek-ahead that distinguishes a table-alias prefix (e.g. a."COL1") from a bare identifier (ROWID): if a '"' appears before whitespace or '=', skip the alias; otherwise read the bare token as the column name.
|
Commits
Review Small, focused change to the Oracle LogMiner SQL_REDO scanner adding support for bare (unquoted) identifiers such as LGTM |
Jeffail
approved these changes
Jul 7, 2026
Jeffail
left a comment
Contributor
There was a problem hiding this comment.
Ace, thanks @josephwoodward!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Oracle, a ROWID is Oracle's internal physical address for a row - it's not a column in the table; it's a pseudo-column Oracle maintains internally and under some circumstances it's possible that OracleDB will fall back to using it to locate rows (tables without primary keys, LOB based operations).
So this change handles such scenario, publishing the change as an event and logging the SQL via the
DEBUGflag (it's possible it could contain sensitive information so should be an opt-in behaviour).