oracledb_cdc: prevent checkpointing during snapshot - #4670
Merged
Conversation
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
josephwoodward
force-pushed
the
jw/snapshotcpregression
branch
from
August 5, 2026 14:23
4b75d1c to
134e6db
Compare
josephwoodward
marked this pull request as ready for review
August 5, 2026 14:57
squiidz
approved these changes
Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A recent change to introduce the current SCN to snapshot events had the undesired knock on effect of checkpointing delivery of those snapshot events, which we only want to do when the snapshot process completes. This change reverts that behaviour and adds a set of regression tests.
Proof of Work
Snapshot completes and only then does it checkpoint: