[26.2] Iceberg monitoring - #1822
Conversation
✅ Deploy Preview for redpanda-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
a3666e1 to
042f7e4
Compare
Per PM review on PR #1822: GetIcebergStatus does more than a reachability ping — it opens the external REST catalog connection (logs in with credentials). Reword the three references from "reachability" to "connectivity"/"connection" to reflect what the endpoint actually tests. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Group the three Iceberg entries (decoded keys/headers, Schema Registry context, health monitoring) under a single "== Iceberg" section as a bullet list instead of scattered top-level sections. Keep configuration properties as its own section. Also fixes two issues in the consolidated region: - Broken xref: health-monitoring pointed to the deleted monitor-iceberg-health.adoc; now points to about-iceberg-topics.adoc#monitor-iceberg-health - Missing blank line before the first section heading Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
"Iceberg" -> "Iceberg translation and health monitoring" to name both themes covered by the section and match the feature-phrase style of the other What's New headings. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
74d762e to
cabcf15
Compare
Docs standards reviewFindings only — 1 and 2 are the substantive ones, 3–9 are discretionary. Critical issues (should fix before merge)1. The proto sets authorization explicitly: rpc GetIcebergStatus(GetIcebergStatusRequest) returns (GetIcebergStatusResponse) {
option (pbgen.rpc) = { authz: SUPERUSER };
}( This isn't just an omission. Fix: keep "read-only" (accurate — the proto calls the service a "public, read-only surface") but add the requirement, for example: ... use the read-only `GetIcebergStatus` Admin API endpoint. This endpoint
requires superuser privileges if authentication is enabled on your cluster.2. Both new deep links 404 until redpanda-data/api-docs#76 ("Admin API v2: add IcebergService and FeaturesService for 26.2") is still open against
It's referenced from Suggestions3. The section is thin for an H2, and has no example request/response. It's currently one paragraph that defers entirely to the API reference. Every comparable Admin API v2 doc on 4. Units of "commit lag" are ambiguous. "how far behind catalog commit is" doesn't say in what. The proto is specific: 5. Worth stating what the endpoint does not return, especially on the troubleshooting page. From the proto: "Translation lag (live-log high watermark minus the translated offset) is a client-side join with the Kafka API and is not returned here." Since 6. Release notes: bullets are inconsistent with the rest of the page. After this change, "Iceberg translation and health monitoring" is the only H2 on 7. Minor — the release note slightly overstates the API. "identify the partitions with the highest commit lag" reads as though the endpoint ranks results; it returns all partitions unsorted, and the reader sorts. Fine as an outcome statement, but "to find the partitions with the highest commit lag" would be more literal. 8. Optional — 9. Judgment call — is the "About" page the right home? |
micheleRP
left a comment
There was a problem hiding this comment.
approving to not block for release, but please see review comments before merging
Description
This pull request adds documentation for a new Iceberg health monitoring feature in Redpanda version 26.2 and updates related references. The most important changes are grouped below:
New Iceberg Health Monitoring Documentation:
about-iceberg-topics.adocdescribing how to monitor Iceberg topic health using the newGetIcebergStatusAdmin API endpoint, including catalog reachability and per-partition commit lag.redpanda.adoc), including a brief description and a link to the new documentation section.Admin API and Cross-References Updates:
use-admin-api.adoc) to include Iceberg health monitoring as a feature available via ConnectRPC endpoints, with a link to the new documentation.Related Admin API PR: redpanda-data/api-docs#76
Resolves https://redpandadata.atlassian.net/browse/DOC-2265
Review deadline: 27 July
Page previews
https://deploy-preview-1822--redpanda-docs-preview.netlify.app/streaming/26.2/manage/iceberg/about-iceberg-topics/#monitor-iceberg-health
https://deploy-preview-1822--redpanda-docs-preview.netlify.app/streaming/26.2/manage/iceberg/iceberg-troubleshooting/#troubleshooting-metrics
https://deploy-preview-1822--redpanda-docs-preview.netlify.app/streaming/26.2/get-started/release-notes/redpanda/
Checks