docs: remove stale rpk ai partials from the llm/mcp rename - #1849
Conversation
The rpai plugin renamed llm to llm-provider and mcp to mcp-server. The regeneration replaced the partials with the new names but the cleanup in the doc-tools version current at the time missed these two, leaving partials for commands that no longer exist. Nothing includes or links them. Verified against the committed rpk snapshot: these are the only two rpk-ai partials with no matching command.
✅ Deploy Preview for redpanda-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Important Review skippedReview was skipped as selected files did not have any reviewable changes. 💤 Files selected but had no reviewable changes (2)
⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
rpk-ai-llm-provider.adoc declares rpk-ai-llm.adoc as a page alias, and Antora fails the build when an alias target resolves to a live page. Delete the stub and its nav entry, matching how rpk-ai-mcp.adoc was handled. The matching stale upstream partial is removed in redpanda-data/docs#1849.
|
No findings. Confirmed both partials are still present on Worth stating in the PR body that this is a hard prerequisite rather than tidy-up: while these two partials exist on |
micheleRP
left a comment
micheleRP
left a comment
There was a problem hiding this comment.
Approving. Verified nothing else references either partial, and this is a prerequisite for the adp-docs stub sync rather than tidy-up. Detail in my comment above.
2 participants
Summary
The rpai plugin renamed
llm→llm-providerandmcp→mcp-server. Regeneration replaced the partials under the new names, but the stale-file cleanup in the doc-tools version current at the time missed two files, leaving partials for commands that no longer exist:modules/reference/partials/rpk-ai/rpk-ai-llm.adocmodules/reference/partials/rpk-ai/rpk-ai-mcp-create.adocVerified against main's committed rpk snapshot (
rpk-v26.2.1-rc2.json): of the 102 rpk-ai partials, these are the only two with no matching command in therpk aisubtree, and nothing inmodules/ordocs-data/includes or links them.(Newer doc-tools sweeps these automatically — docs-extensions-and-macros#225's runs delete them as stale — but removing them now keeps the tree clean regardless of merge order.)
Related PRs (rpk docs automation train)
--pluginmode, change detection, deprecations, What's-new merge, flag extraction, stub reconciler (publishes doc-tools 5.3.0)Merge order: #225 → dependency bumps on docs main and beta → #1834 + #1844 (+ #1849) → #1852 + adp-docs#165 → remaining senders. Jira: DOC-2355, DOC-1090.