docs: stop excluding rpk ai connection from the rpk reference - #1869
Conversation
The rpk ai connection command group graduated from a coming-soon stub to working commands (list, revoke) in plugin v0.2.32 and is announced in the ADP release notes. The exclude overrides date from the stub era and now suppress the pages for a shipped, release-noted feature: the plugin-docs regen (docs PR #1868) refreshed the snapshot with the connection commands but rendered nothing for them because of these entries. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
✅ Deploy Preview for redpanda-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
📝 WalkthroughWalkthroughThe documentation override file no longer excludes Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
JakeSCahill
left a comment
There was a problem hiding this comment.
Verified: clean removal of the three stub-era excludes, and the #1868 snapshot already carries the connection commands with real help text, so the re-dispatch will render them (pages, nav, and the adp-docs reconcile downstream). One non-blocking nit: the excluded_commands doc-string at the top of the file still mentions the connection subtree — worth sweeping in #1865 since it edits neighboring entries.
What
Remove the three
excludeoverrides forrpk ai connection,rpk ai connection list, andrpk ai connection revokefromdocs-data/rpk-overrides.json.Why
The
rpk ai connectiongroup graduated from a coming-soon stub to working commands in plugin v0.2.32, and the ADP release notes announce it as a feature. The excludes date from the stub era. With them in place, the plugin-docs regen (#1868) refreshes the snapshot correctly (the connection commands are present with real help text) but renders no pages for them:shouldExcludeCommandwalks these entries and drops the subtree.After this merges, re-dispatching
update-rpk-plugin-docs.ymlforaiupdates #1868 in place with the connection partials.Related: #1865 cleans up other stale rpk ai override paths (the
rpk ai llm checkwarnings in the regen log) but doesn't touch these entries; the two changes are independent.🤖 Generated with Claude Code