Repair conflict markers merged into rpk-overrides.json - #1874
Conversation
The #1838 squash-merge landed with three unresolved conflict hunks, leaving the overrides file invalid JSON on main (my rebase resolution script failed partway and the follow-on commands ran anyway). Rebuilt semantically: the last valid state (post-#1865) plus selfHostedOnly on exactly the 22 cloud-unavailable commands #1838 intended, verified against the DOC-2407 target list. Every diff line against the pre-merge state is a selfHostedOnly addition, nothing else.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
✅ Deploy Preview for redpanda-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
…aves Resolves the rpk-overrides.json conflict by semantic reconstruction: main's last valid state plus the #1838 selfHostedOnly gating (22 commands, re-asserted for the two whose entries this PR empties) plus this PR's 55 content deltas, each set verified programmatically. This also repairs the invalid JSON that the #1838 squash-merge left on main (three unresolved conflict hunks), superseding the standalone hotfix in #1874.
|
Superseded: the same repaired overrides data landed on main via #1862 (approved branch, merge commit + escape restore). Verified post-merge: main's rpk-overrides.json is valid JSON, 22 selfHostedOnly entries, no markers. |
Hotfix — main's
docs-data/rpk-overrides.jsonis currently invalid JSON. The #1838 squash-merge landed with three unresolved conflict hunks: my rebase-resolution script failed its own assertion partway through, but the follow-on git commands were not chained to it and staged the conflicted file anyway. Full accounting below; fix first.Fix approach — semantic rebuild, not marker surgery (text surgery is what broke it): took the last valid state (post-#1865,
main~1) and applied #1838's exact intent programmatically —selfHostedOnly: trueon the 22 cloud-unavailable commands, verified against the DOC-2407 target list. Every line of the diff against the pre-merge state is either aselfHostedOnlyaddition, the trailing comma it forces on the preceding key, or a new object key for a command that had no entry. Nothing else changes; the file parses and carries exactly 22selfHostedOnlyentries and all of main'sintroducedInVersionstamps.Blast radius while broken: any doc-tools run against main fails at overrides load. #1863 (auto-rerender) is not merged yet, so no automation consumed the broken file.
validate-docs-dataCI on main should be red for the merge commit.Process fix on my side: resolution scripts and the git commands that depend on them must be one chained command, and I now read back the merged file after any merge I drive — the same read-back-your-writes rule from TESTING_AUTOMATIONS.adoc that I wrote and then violated.
Jira
Part of the DOC-2407 fix chain (this delivers #1838's data correctly).