Skip to content

Serverless API docs improvements - #657

Closed
kbatuigas wants to merge 9 commits into
mainfrom
serverless-api-doc-impvt
Closed

Serverless API docs improvements#657
kbatuigas wants to merge 9 commits into
mainfrom
serverless-api-doc-impvt

Conversation

@kbatuigas

@kbatuigas kbatuigas commented Jul 31, 2024

Copy link
Copy Markdown
Contributor

Description

Resolves https://github.com/redpanda-data/documentation-private/issues/2629
Review deadline: 1 Aug

  • Add more guidance for quickstart
  • For serverless, move long-running operations section to end of doc, so users can get through the task steps quickly

Page previews

API Quickstart
Use the Control Plane API with Serverless

Checks

  • New feature
  • Content gap
  • Support Follow-up
  • Small fix (typos, links, copyedits, etc)

@netlify

netlify Bot commented Jul 31, 2024

Copy link
Copy Markdown

Deploy Preview for redpanda-docs-preview ready!

Name Link
🔨 Latest commit f7b5c39
🔍 Latest deploy log https://app.netlify.com/sites/redpanda-docs-preview/deploys/66aba8c2ec0b9400079d85a4
😎 Deploy Preview https://deploy-preview-657--redpanda-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Deflaimun
Deflaimun force-pushed the serverless-api-doc-impvt branch from 96db235 to 9046cf3 Compare July 31, 2024 18:07
@kbatuigas
kbatuigas marked this pull request as ready for review July 31, 2024 18:12
@kbatuigas
kbatuigas requested a review from a team as a code owner July 31, 2024 18:12

@ajyoung ajyoung left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the "Make a request to the Data Plane APIs" section, consider replacing "Get Cluster" with "Get Cluster or Serverless Cluster" in steps 1 and 2.

+
[,bash]
----
curl -H 'Authorization: Bearer <token>' https://api.redpanda.com/v1beta2/serverless/regions?cloud_provider=CLOUD_PROVIDER_AWS

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Single quotes are needed around the last argument (the URL) because otherwise the question mark will be interpreted as a shell character instead of as part of the URL.

One other thing, we may want to note somewhere that if the bearer token is filled in with a shell substitution variable (e.g. curl -H "Authorization: Bearer $TOKEN" https://api.redpanda.com/v1beta2/resource-groups), then that argument to the command needs to be surrounded by double quotes rather than single quotes. This is a well known thing but people may forget when copy/pasting commands. This is less important but just a thought.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ajyoung , I have exactly the same suggestion

[,bash]
----
curl -H 'Authorization: Bearer <token>' https://api.redpanda.com/v1beta2/serverless/regions/
curl -H 'Authorization: Bearer <token>' https://api.redpanda.com/v1beta2/serverless/regions?cloud_provider=CLOUD_PROVIDER_AWS

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Single quotes are needed around the last argument (the URL) because otherwise the question mark will be interpreted as a shell character instead of as part of the URL.

Comment thread modules/deploy/partials/cloud/controlplane-api.adoc Outdated
Comment thread modules/deploy/partials/cloud/controlplane-api.adoc Outdated

@Feediver1 Feediver1 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor suggestions

@kbatuigas
kbatuigas force-pushed the serverless-api-doc-impvt branch from 9046cf3 to 3c866bf Compare August 1, 2024 02:05
Co-authored-by: Joyce Fee <102751339+Feediver1@users.noreply.github.com>

@vladoschreiner vladoschreiner left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Feediver1

Copy link
Copy Markdown
Contributor

Given that you merged redpanda-data/cloud-docs#10, can you close this one @kbatuigas ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants