bazel: upgrade to bazel 8#25368
Merged
rockwotj merged 13 commits intoredpanda-data:devfrom Apr 17, 2025
Merged
Conversation
Collaborator
CI test resultstest results on build#63204
test results on build#64359
test results on build#64392
test results on build#64647
test results on build#64663
|
rockwotj
requested review from
dotnwat,
michael-redpanda,
mmaslankaprv and
travisdowns
dotnwat
previously approved these changes
Apr 10, 2025
Contributor
Author
|
Enabling seastar assertions in release mode trips up the fetch benchmark, will investigate more |
Member
|
@rockwotj we are working (struggling) to get bazel microbenchmarks fully enabled in bazel with baseline results, it would be great to have that working and with some data points before this goes in (should be up tomorrow), WDYT? |
Contributor
Author
|
Yeah that's a good idea. I'll wait a week before merging this |
Contributor
Author
Okay I believe I've fixed this issue. Will hold off on merging until microbenchmarks are stable in Bazel. |
Member
Thank you, we are getting there. |
Contributor
Author
|
I've reverted the clang-19 upgrade and just upgraded to bazel 8 which will help a ton with these silly lockfile conflicts. |
Contributor
Author
|
I will upgrade to clang 19 after we have benchmarks stable, but I would love to get this in |
Collaborator
Retry command for Build#64639please wait until all jobs are finished before running the slash command |
This time with libxml2 disabled so CI doesn't choke.
``` explicit specialization cannot have a storage class ```
From libc++19 release notes: > libc++ no longer supports std::allocator<const T> and containers of const-qualified element type, such as std::vector<const T> and std::list<const T>. This used to be supported as an undocumented extension. If you were using std::vector<const T>, replace it with std::vector<T> instead. The _LIBCPP_ENABLE_REMOVED_ALLOCATOR_CONST macro can be defined to temporarily re-enable this extension. to temporarily re-enable this extension to make it easier to update user code This macro will be honored for one released and ignored starting in LLVM 20. To assist with the clean-up process, consider running your code through Clang Tidy, with std-allocator-const enabled.
From libc++19 release notes: > libc++ no longer supports std::allocator<const T> and containers of const-qualified element type, such as std::vector<const T> and std::list<const T>. This used to be supported as an undocumented extension. If you were using std::vector<const T>, replace it with std::vector<T> instead. The _LIBCPP_ENABLE_REMOVED_ALLOCATOR_CONST macro can be defined to temporarily re-enable this extension. to temporarily re-enable this extension to make it easier to update user code This macro will be honored for one released and ignored starting in LLVM 20. To assist with the clean-up process, consider running your code through Clang Tidy, with std-allocator-const enabled.
To fix an warning that crops up in Bazel 8
This picks up the new SEASTAR_ASSERT macro, which removes some warnings from the build in Bazel.
This brings vastly better lockfile management and will cause many less merge conflicts because of the silly lockfile in Bazel.
This was not cleaned up properly, which since we moved to a newer version of Seastar that had asserts turned on in release mode, it caught these issues of not properly stopping the sharded abort source.
Also upgrade re2 to get past bazelbuild/bazel#24426
Collaborator
Retry command for Build#64647please wait until all jobs are finished before running the slash command |
Contributor
Author
|
/ci-repeat 1 |
Member
I thought they were now but looks like they are broken again because of some task issues. Will be looking shortly. |
StephanDollberg
approved these changes
Apr 17, 2025
Contributor
Author
|
/ci-repeat 1 |
Collaborator
Retry command for Build#64663please wait until all jobs are finished before running the slash command |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrade bazel to v8
and also upgrade clang-19 build and seastar. Kind of a mash of lots of build related stuff :)
Backports Required
Release Notes