kafka/server: Metadata: Do not return new topics before voting #26160
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a topic is created, it is added to metadata_cache prior to having a leader. The leader_epoch is 0, which can conflict with a previous topic of the same name. After voting, the term_id is set correctly, resulting in a correct leader_epoch, which allows a consumer to detect the change. This commit detects that a topic is new by not returning partitions that have never had a leader; if there are no partitions, the topic is rejected as unknown. Signed-off-by: Ben Pope <ben@redpanda.com>
Member
Author
|
Closed by #26968 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: Do not merge, just running this against the full test suite.
When a topic is created, it is added to metadata_cache prior to having a leader. The leader_epoch is 0, which can conflict with a previous topic of the same name.
After voting, the term_id is set correctly, resulting in a correct leader_epoch, which allows a consumer to detect the change.
This commit detects that a topic is new by not returning partitions that have never had a leader; if there are no partitions, the topic is rejected as unknown.
TODO:
Backports Required
Release Notes
Features