-
Notifications
You must be signed in to change notification settings - Fork 705
DNM: log segment locking #26256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
andrwng
wants to merge
2
commits into
redpanda-data:dev
Choose a base branch
from
andrwng:logging-rwlock-segment-lock
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
DNM: log segment locking #26256
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a wrapper around ss::rwlock that logs when lock acquisition takes longer than a default of 10s. It is meant to be a drop-in replacement, though this commit only adds just enough of the ss::rwlock API to replace current usages in the context of segment locks. The following logging will occur: - trace message is logged when lock attempt is started - trace message is logged when lock is acquired - trace message is logged when lock is dropped - error message is logged when a lock takes longer than 10s to acquire The ss::rwlock::holder abstraction is also copied with a ssx::logging_rwlock::holder, which includes a holder ID that is also logged, allowing for easier correlation between log messages. This will be useful in debugging deadlocks among the storage layer.
Acquisition of segment locks span the raft, storage, and archival subsystems, making it very difficult to determine what fiber is holding what lock or whether slowness is caused by the waiting on a lock. To remedy this, this replaces the segment locks with a logging_rwlock.
41026db to
6a0016c
Compare
Collaborator
Retry command for Build#66457please wait until all jobs are finished before running the slash command |
Collaborator
CI test resultstest results on build#66457
test results on build#66532
|
Contributor
Author
|
/ci-repeat 10 |
Contributor
Author
|
/ci-repeat 3 dt-repeat=4 skip-redpanda-build skip-units |
Contributor
Author
|
/ci-repeat 10 skip-redpanda-build skip-units |
Collaborator
Retry command for Build#66532please wait until all jobs are finished before running the slash command |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Debugging
Backports Required
Release Notes