k/tests: retry creating topic in topic recreate test #26321
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes it may happen that the client will receive not leader controller reply. In this case we must retry creating topic to make sure the rest of the test passes. Signed-off-by: Michał Maślanka <michal@redpanda.com>
ztlpn
approved these changes
Jun 3, 2025
bashtanov
reviewed
Jun 3, 2025
| auto resp | ||
| = client.dispatch(std::move(req), kafka::api_version(2)).get(); | ||
| if ( | ||
| resp.data.topics.begin()->error_code == kafka::error_code::none) { |
Contributor
There was a problem hiding this comment.
What's the actual error returned if controller leadership has changed? Are we okay to swallow any other errors?
Member
Author
There was a problem hiding this comment.
the test will still fail if retries are exhausted
Collaborator
CI test resultstest results on build#66747
|
Collaborator
|
/backport v25.1.x |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes it may happen that the client will receive not leader controller reply. In this case we must retry creating topic to make sure the rest of the test passes.
Backports Required
Release Notes