[CORE-13043] cluster_link: enable changing bootstrap servers with update shadow link command #27986
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enables updating bootstrap servers and TLS configuration for cluster links through the shadow link update command. Previously, these configuration changes were disallowed but are now supported with proper broker connection management.
- Removes restrictions on updating bootstrap_servers and tls_settings in shadow links
- Implements broker configuration updates that properly restart client connections when brokers or TLS settings change
- Adds comprehensive test coverage for the new functionality
Reviewed Changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
tests/rptest/tests/cluster_linking_topic_syncing_test.py |
Refactors TLS provider class to shared location |
tests/rptest/tests/cluster_linking_test_base.py |
Moves ClusterLinkingTLSProvider here as shared utility |
tests/rptest/tests/cluster_linking_e2e_test.py |
Adds new test class ShadowLinkUpdateBrokersTests with test for broker updates |
src/v/redpanda/admin/services/shadow_link/shadow_link.cc |
Removes validation that blocked bootstrap_servers and tls_settings updates |
src/v/net/tls.h |
Adds equality operators for TLS-related structs |
src/v/kafka/client/configuration.h |
Adds equality operator for tls_configuration |
src/v/kafka/client/cluster.h |
Adds update_broker_config method and configuration getter |
src/v/kafka/client/cluster.cc |
Implements broker configuration update with proper connection management |
src/v/kafka/client/brokers.h |
Adds clear method declaration |
src/v/kafka/client/brokers.cc |
Implements clear method to remove all brokers |
src/v/kafka/client/BUILD |
Adds dependency on unresolved_address utility |
src/v/cluster_link/utils.h |
Adds declarations for TLS and SASL configuration creation functions |
src/v/cluster_link/utils.cc |
Refactors configuration creation functions to return optionals |
src/v/cluster_link/manager.cc |
Changes update_config call to be async |
src/v/cluster_link/link.h |
Makes update_config async and adds broker configuration update method |
src/v/cluster_link/link.cc |
Implements async configuration updates with broker connection management |
bharathv
reviewed
Oct 9, 2025
IoannisRP
force-pushed
the
CORE-13043/change-bootstrap-servers
branch
from
c20d5a8 to
cf01115
Compare
Contributor
Author
|
changes in force-push:
|
Collaborator
Retry command for Build#73938please wait until all jobs are finished before running the slash command |
michael-redpanda
previously approved these changes
Oct 10, 2025
Contributor
michael-redpanda
left a comment
michael-redpanda
left a comment
There was a problem hiding this comment.
lgtm - want to see if @bharathv is happy with your response and then we can merge
IoannisRP
force-pushed
the
CORE-13043/change-bootstrap-servers
branch
from
cf01115 to
0e562c6
Compare
Contributor
Author
|
Changes in force-push:
|
bharathv
previously approved these changes
Oct 10, 2025
| && broker_tls == client_config.broker_tls) { | ||
| return ss::now(); | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
this is worthy of an info log IMO.
Collaborator
Retry command for Build#73956please wait until all jobs are finished before running the slash command |
michael-redpanda
previously approved these changes
Oct 10, 2025
Collaborator
Member
|
Can we merge this after: #27703 ? |
michael-redpanda
dismissed stale reviews from bharathv and themself
via
82006ea
michael-redpanda
force-pushed
the
CORE-13043/change-bootstrap-servers
branch
from
0e562c6 to
82006ea
Compare
Contributor
|
Force push:
|
Contributor
|
The type checking issue was fixed here: #28134 |
Contributor
michael-redpanda
left a comment
michael-redpanda
left a comment
There was a problem hiding this comment.
looks good - would be interested in having @mmaslankaprv take a quick peak since he has done so much work in kafka/client/cluster
bharathv
reviewed
Oct 21, 2025
Collaborator
Retry command for Build#74614please wait until all jobs are finished before running the slash command |
IoannisRP
force-pushed
the
CORE-13043/change-bootstrap-servers
branch
from
9a50f05 to
5946d44
Compare
Contributor
Author
|
changes in force-push:
|
bharathv
previously approved these changes
Oct 22, 2025
These tests don't call start, so they didn't need to call stop, till now. In the next commit, an ssx::work_queue will be added to the kafka client cluster, which makes the call to stop mandatory, even if it hasn't been started.
…luster This commit also add all the functionality needed to restart brokers. In the update config, we restart the brokers to pick up the config.
Because of the difficulty involved in changing the address of a cluster in dt, this test is a workaround. The second source cluster is meant to represent a change of broker address.
IoannisRP
force-pushed
the
CORE-13043/change-bootstrap-servers
branch
from
5946d44 to
343caba
Compare
Contributor
Author
|
changes in force-push:
|
bharathv
approved these changes
Oct 23, 2025
Collaborator
Retry command for Build#74750please wait until all jobs are finished before running the slash command |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements: CORE_13043
Add path to handle changes in bootstrap_servers and/or tls config of a cluster link.
When either one of these change as part of a shadow link update request, the brokers in the
kafka::client::clusterneed to be brought down and be remade using the new seeds/tls config.Backports Required
Release Notes