c/rm_stm: downgrade log level of skipping cleanup#30174
Merged
bharathv merged 1 commit intoredpanda-data:devfrom Apr 15, 2026
Merged
c/rm_stm: downgrade log level of skipping cleanup#30174bharathv merged 1 commit intoredpanda-data:devfrom
bharathv merged 1 commit intoredpanda-data:devfrom
Conversation
Producer cleanup may be skipped due to a race condition where a producer is marked active in the brief interval between being flagged for eviction and the actual cleanup. This is a legit race at scale and eviction pressure.
bharathv
requested review from
bashtanov,
Copilot,
joe-redpanda and
mmaslankaprv
Contributor
Author
|
Backport reason: avoid test failures in older branches. |
Contributor
There was a problem hiding this comment.
Pull request overview
Adjusts rm_stm producer-cleanup logging to reflect that “skipped cleanup” can be a legitimate outcome under eviction/transaction races at scale, reducing unnecessary error-level noise in operational logs.
Changes:
- Downgraded log level from
errortoinfowhen skipping producer cleanup due to an in-progress transaction. - Downgraded log level from
errortoinfowhen the pending-cleanup PID no longer matches the current producer state (race/eviction churn).
bashtanov
approved these changes
Apr 15, 2026
Contributor
|
What happens if a producer gets cleaned up with linked transaction state? Do we leak resources? |
Contributor
Author
we have checks to make sure it doesn't happen. |
Collaborator
|
/backport v26.1.x |
Collaborator
|
/backport v25.3.x |
Collaborator
|
/backport v25.2.x |
This was referenced Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Producer cleanup may be skipped due to a race
condition where a producer is marked active in
the brief interval between being flagged for
eviction and the actual cleanup.
This is a legit race at scale and eviction pressure.
Backports Required
Release Notes