[v26.1.x] cloud_io: apply throughput percent on each recompute#30233
Merged
nvartolomei merged 2 commits intoredpanda-data:v26.1.xfrom Apr 20, 2026
Merged
Conversation
`cloud_storage_throughput_limit_percent` is a live setting, but the device throughput was scaled by the percent once at startup and cached in `_device_throughput`. Subsequent changes to the percent had no effect on the disk limit. Additionally, if the percent was zero at startup, `_device_throughput` stayed unset and flipping the percent later would not engage disk throttling. Store the raw device throughput and apply the percent on every `update_throughput()` call so live changes take effect. (cherry picked from commit 0fca3af)
Both config bindings (`cloud_storage_max_throughput_per_shard`, `cloud_storage_throughput_limit_percent`) and `start()` trigger `update_throughput()`. Since it contains a `co_await` inside `set_disk_max_bandwidth`, concurrent invocations can interleave and leave the final throughput reflecting a stale config instead of the latest. Serialize with a per-shard mutex so updates run to completion in order. (cherry picked from commit 1c39724)
nvartolomei
approved these changes
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of PR #30230