Skip to content

[v26.1.x] datalake: validate iceberg_rest_catalog_endpoint at config time#30568

Merged
WillemKauf merged 1 commit into
redpanda-data:v26.1.xfrom
vbotbuildovich:backport-pr-30535-v26.1.x-558
May 22, 2026
Merged

[v26.1.x] datalake: validate iceberg_rest_catalog_endpoint at config time#30568
WillemKauf merged 1 commit into
redpanda-data:v26.1.xfrom
vbotbuildovich:backport-pr-30535-v26.1.x-558

Conversation

@vbotbuildovich
Copy link
Copy Markdown
Collaborator

@vbotbuildovich vbotbuildovich commented May 21, 2026

Backport of PR #30535

@WillemKauf @vbotbuildovich
datalake: validate iceberg_rest_catalog_endpoint at config time
fccf3be 
A malformed `iceberg_rest_catalog_endpoint` (e.g. one that fails
`ada::parse`) causes start-up to fail, originating from a throw in
`endpoint_to_address` and propagated out of `datalake_manager::start()`/
`coordinator_manager::start()`. There is no opportunity for the user to
correct the value short of editing the cluster config file by hand.

Extract the URL-parse check into `datalake::parse_iceberg_rest_catalog_endpoint()`,
have `endpoint_to_address` call it first, and apply the same check as a
property validator on `iceberg_rest_catalog_endpoint` so bad values are
rejected by `rpk cluster config set` rather than crashing the broker on
the next restart.

(cherry picked from commit eaaaae4)
@vbotbuildovich vbotbuildovich requested a review from a team as a code owner May 21, 2026 00:24
@vbotbuildovich vbotbuildovich added this to the v26.1.x-next milestone May 21, 2026
@vbotbuildovich vbotbuildovich added the kind/backport PRs targeting a stable branch label May 21, 2026
@vbotbuildovich vbotbuildovich requested a review from WillemKauf May 21, 2026 00:24
@vbotbuildovich
Copy link
Copy Markdown
Collaborator Author

vbotbuildovich commented May 21, 2026

Retry command for Build#84773

please wait until all jobs are finished before running the slash command

/ci-repeat 1
skip-redpanda-build
skip-units
skip-rebase
tests/rptest/tests/write_caching_fi_e2e_test.py::WriteCachingFailureInjectionE2ETest.test_crash_all@{"use_transactions":false}

@vbotbuildovich
Copy link
Copy Markdown
Collaborator Author

vbotbuildovich commented May 21, 2026

CI test results

test results on build#84773
test_status test_class test_method test_arguments test_kind job_url passed reason test_history
FLAKY(PASS) ShadowLinkingReplicationTests test_replication_with_failures null integration https://buildkite.com/redpanda/redpanda/builds/84773#019e4803-c0fa-479a-a729-32c5d0acc21e 10/11 Test PASSES after retries.No significant increase in flaky rate(baseline=0.0000, p0=1.0000, reject_threshold=0.0100. adj_baseline=0.1000, p1=0.3487, trust_threshold=0.5000) https://redpanda.metabaseapp.com/dashboard/87-tests?tab=142-dt-individual-test-history&test_class=ShadowLinkingReplicationTests&test_method=test_replication_with_failures
FLAKY(FAIL) WriteCachingFailureInjectionE2ETest test_crash_all {"use_transactions": false} integration https://buildkite.com/redpanda/redpanda/builds/84773#019e4808-093c-45b3-96f1-50ba570e9d34 16/21 Test FAILS after retries.Significant increase in flaky rate(baseline=0.0370, p0=0.0057, reject_threshold=0.0100) https://redpanda.metabaseapp.com/dashboard/87-tests?tab=142-dt-individual-test-history&test_class=WriteCachingFailureInjectionE2ETest&test_method=test_crash_all

@WillemKauf WillemKauf merged commit ad668ab into redpanda-data:v26.1.x May 22, 2026
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@WillemKauf WillemKauf WillemKauf approved these changes

Assignees

No one assigned

Labels

area/build area/redpanda kind/backport PRs targeting a stable branch

Projects

None yet

Milestone

v26.1.x-next

Development

Successfully merging this pull request may close these issues.

2 participants

@vbotbuildovich @WillemKauf