Adjusts @redux-devtools/cli --open flag to respect protocol and host
#1217
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently when using open, the cli will ignore the host and protocol and always open `http://localhost`. This pr adjusts the open script to use the options protocol and host and default back to localhost if not provided.
🦋 Changeset detectedLatest commit: 2cd9cbb The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
smacpherson64
changed the title
--open flag to respect protocol and host
Contributor
Author
|
Hi @Methuselah96, sorry for pinging! I was wondering what the process is about pull requests for |
Methuselah96
approved these changes
Jan 8, 2023
Member
Methuselah96
left a comment
Methuselah96
left a comment
There was a problem hiding this comment.
Thanks, sorry for the delayed review!
Contributor
Author
|
No worries! Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the redux-devtools-cli, currently when using the
--openflag the host and protocol options are ignored and openshttp://localhost(causing a blank screen).This PR adjusts
--opento use the provided protocol and host options when possible.