Skip to content

Hide author's name from list of LGTMs we need to get #126

@sethladd

Description

@sethladd

git reflow says that it needs an LGTM from me, even though it really doesn't :)

For example:

~/Code/dartdoc[sl-underscores] $ git reflow deliver
git fetch origin master
From github.com:dart-lang/dartdoc
 * branch            master     -> FETCH_HEAD

git checkout sl-underscores
Already on 'sl-underscores'
Your branch is up-to-date with 'origin/sl-underscores'.
git pull origin sl-underscores
From github.com:dart-lang/dartdoc
 * branch            sl-underscores -> FETCH_HEAD
Already up-to-date.
git checkout sl-underscores
Already on 'sl-underscores'
Your branch is up-to-date with 'origin/sl-underscores'.
[deliver halted] You still need a LGTM from: devoncarew, sethladd

Expected:

[deliver halted] You still need a LGTM from: devoncarew

(because sethladd is the author of the patch)

Also:

~/Code/dartdoc[sl-underscores] $ git reflow review

Review your PR:
--------
Title:
sl-underscores

Body:

--------
Submit pull request? (Y)
y
git fetch origin master
From github.com:dart-lang/dartdoc
 * branch            master     -> FETCH_HEAD

git push origin sl-underscores
Counting objects: 5, done.
Delta compression using up to 4 threads.
Compressing objects: 100% (5/5), done.
Writing objects: 100% (5/5), 555 bytes | 0 bytes/s, done.
Total 5 (delta 4), reused 0 (delta 0)
To git@github.com:dart-lang/dartdoc.git
   05f7941..4e528dc  sl-underscores -> sl-underscores

A pull request already exists for these branches:
    Build status:  All necessary CLAs are signed
    Last comment:  "lgtm\r\n\r\nre: the dartfmt output, you can always disable the formatting check for now. That way we'll still have analysis and test coverage."
    branches:      dart-lang:sl-underscores -> dart-lang:master
    number:        762
    reviewed by:   devoncarew, sethladd
    url:           https://github.com/dart-lang/dartdoc/pull/762

Expected:

reviewed by: devoncarew

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions