Fix review message parsing from editor failed#133
Merged
nhance merged 1 commit intoreenhanced:masterfrom Sep 10, 2015
Merged
Conversation
In the editor, when I wrote out ``` a b ``` the pull request's title only "b", and there was no body: ``` Review your PR: -------- Title: b Body: -------- Submit pull request? (Y) ``` With this change, I get the expected title and body: ``` Review your PR: -------- Title: a Body: b -------- Submit pull request? (Y) ```
Member
|
lgtm (We'll likely merge in next week, this is a holiday weekend for us) |
nhance
added a commit
that referenced
this pull request
Sep 10, 2015
Fix review message parsing from editor failed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the editor, when I wrote out
the pull request's title only "b", and there was no body:
With this change, I get the expected title and body: