fix(react-hook-form): correctly handle unsaved changes warning (#6691) #6702
+10
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…edev#6691) Used useEffect to track isDirty and update setWarnWhen accordingly.
🦋 Changeset detectedLatest commit: 4c7a748 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for refine-doc-live-previews ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Member
|
It's look good, Thanks for improving Refine 🙌 Do you have time to write tests? |
Contributor
|
Hey guys, what's the status on this? Need this change in. |
Member
|
Closed due to inactivity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Used useEffect to track isDirty and update setWarnWhen accordingly.
PR Checklist
Please check if your PR fulfills the following requirements:
Bugs / Features
What is the current behavior?
When setting
warnWhenUnsavedChanges: true, if the user changes a field but then undo the change and try to navigate to another page, the warn modal pops up even if there aren't no real data changes.What is the new behavior?
setWarnWhenis now controlled by[isDirty](https://react-hook-form.com/docs/useform/formstate), ensuring that it only shows the warning when the form has been modified.fixes (#6691)