Wire collections to API data and enable editable JSON collections#336
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary\n- add search + total support to for curated JSON collections\n- add flow (without ownerHandle) to create custom JSON-backed collections with skill slug validation\n- keep ownerHandle/supabase flows intact for personal collections\n- rename dynamic API segment to and keep UUID-compatible behavior for personal routes\n- wire and pages to fetch from collection APIs instead of direct data imports\n\n## Validation\n-
/private/tmp/fa-collections/tests/glossary-page.test.tsx
187:35 warning 'getByText' is assigned a value but never used @typescript-eslint/no-unused-vars
/private/tmp/fa-collections/tests/integrations-detail-page.test.tsx
151:14 warning 'error' is defined but never used @typescript-eslint/no-unused-vars
/private/tmp/fa-collections/tests/notifications-page.test.tsx
121:31 warning 'onValueChange' is defined but never used @typescript-eslint/no-unused-vars
/private/tmp/fa-collections/tests/partners-detail-page.test.tsx
175:14 warning 'error' is defined but never used @typescript-eslint/no-unused-vars
/private/tmp/fa-collections/tests/partners-page.test.tsx
202:11 warning 'otherPartners' is assigned a value but never used @typescript-eslint/no-unused-vars
/private/tmp/fa-collections/src/app/accessibility/page.tsx
1:8 warning 'Link' is defined but never used @typescript-eslint/no-unused-vars
/private/tmp/fa-collections/src/app/analytics/heatmap/page.tsx
314:61 warning 'index' is defined but never used @typescript-eslint/no-unused-vars
/private/tmp/fa-collections/src/app/api-docs/api-docs-client.tsx
99:28 warning 'language' is assigned a value but never used @typescript-eslint/no-unused-vars
/private/tmp/fa-collections/src/app/api/recommendations/route.ts
3:10 warning 'NEED_CATEGORIES' is defined but never used @typescript-eslint/no-unused-vars
/private/tmp/fa-collections/src/app/creators/[username]/page.tsx
6:10 warning 'Breadcrumbs' is defined but never used @typescript-eslint/no-unused-vars
/private/tmp/fa-collections/src/app/creators/[username]/stats/page.tsx
4:10 warning 'Breadcrumbs' is defined but never used @typescript-eslint/no-unused-vars
/private/tmp/fa-collections/src/app/diagnostics/diagnostics-client.tsx
35:18 warning 'e' is defined but never used @typescript-eslint/no-unused-vars
/private/tmp/fa-collections/src/app/economics/compare/page.tsx
1:1 warning Unused eslint-disable directive (no problems were reported from 'react/no-unescaped-entities')
/private/tmp/fa-collections/src/app/economics/page.tsx
1:1 warning Unused eslint-disable directive (no problems were reported from 'react/no-unescaped-entities')
/private/tmp/fa-collections/src/app/get-started/page.tsx
4:10 warning 'Breadcrumbs' is defined but never used @typescript-eslint/no-unused-vars
5:8 warning 'Link' is defined but never used @typescript-eslint/no-unused-vars
/private/tmp/fa-collections/src/app/interop/[protocol]/page.tsx
1:1 warning Unused eslint-disable directive (no problems were reported from 'react/no-unescaped-entities')
/private/tmp/fa-collections/src/app/interop/decision-guide/decision-guide-client.tsx
3:1 warning Unused eslint-disable directive (no problems were reported from 'react/no-unescaped-entities')
/private/tmp/fa-collections/src/app/interop/decision-guide/page.tsx
1:1 warning Unused eslint-disable directive (no problems were reported from 'react/no-unescaped-entities')
/private/tmp/fa-collections/src/app/interop/page.tsx
1:1 warning Unused eslint-disable directive (no problems were reported from 'react/no-unescaped-entities')
/private/tmp/fa-collections/src/app/mcp/health/[slug]/page.tsx
1:1 warning Unused eslint-disable directive (no problems were reported from 'react/no-unescaped-entities')
/private/tmp/fa-collections/src/app/mcp/health/page.tsx
1:1 warning Unused eslint-disable directive (no problems were reported from 'react/no-unescaped-entities')
/private/tmp/fa-collections/src/app/memory-patterns/[pattern]/page.tsx
1:1 warning Unused eslint-disable directive (no problems were reported from 'react/no-unescaped-entities')
/private/tmp/fa-collections/src/app/memory-patterns/cookbook/page.tsx
1:1 warning Unused eslint-disable directive (no problems were reported from 'react/no-unescaped-entities')
/private/tmp/fa-collections/src/app/memory-patterns/page.tsx
1:1 warning Unused eslint-disable directive (no problems were reported from 'react/no-unescaped-entities')
/private/tmp/fa-collections/src/app/metrics/page.tsx
80:9 warning 'getStatusColor' is assigned a value but never used @typescript-eslint/no-unused-vars
/private/tmp/fa-collections/src/app/migrate/guide/page.tsx
13:3 warning 'TrendingUp' is defined but never used @typescript-eslint/no-unused-vars
31:8 warning 'skillVersions' is defined but never used @typescript-eslint/no-unused-vars
170:38 warning 'idx' is defined but never used @typescript-eslint/no-unused-vars
/private/tmp/fa-collections/src/app/observability-guide/tracing/page.tsx
3:10 warning 'useState' is defined but never used @typescript-eslint/no-unused-vars
/private/tmp/fa-collections/src/app/observability/page.tsx
3:15 warning 'Metadata' is defined but never used @typescript-eslint/no-unused-vars
/private/tmp/fa-collections/src/app/page.tsx
1:1 warning Unused eslint-disable directive (no problems were reported from 'react/no-unescaped-entities')
/private/tmp/fa-collections/src/app/playground/PlaygroundClient.tsx
197:6 warning React Hook useEffect has a missing dependency: 'selectedEndpoint?.params'. Either include it or remove the dependency array react-hooks/exhaustive-deps
/private/tmp/fa-collections/src/app/search/page.tsx
391:13 warning The attribute aria-expanded is not supported by the role searchbox jsx-a11y/role-supports-aria-props
/private/tmp/fa-collections/src/app/skills/[slug]/page.tsx
1:1 warning Unused eslint-disable directive (no problems were reported from 'react/no-unescaped-entities')
16:10 warning 'Breadcrumbs' is defined but never used @typescript-eslint/no-unused-vars
/private/tmp/fa-collections/src/components/compare/CompareSkillsPageClient.tsx
140:6 warning React Hook useEffect has a missing dependency: 'effectiveSlugs'. Either include it or remove the dependency array react-hooks/exhaustive-deps
140:7 warning React Hook useEffect has a complex expression in the dependency array. Extract it to a separate variable so it can be statically checked react-hooks/exhaustive-deps
✖ 38 problems (0 errors, 38 warnings)
0 errors and 13 warnings potentially fixable with the
--fixoption. (0 errors, warnings only)