Skip to content

ENG-10800: Update XY stars count on the marketing pages - #6843

Merged
Alek99 merged 1 commit into
mainfrom
carlos/update-stars-count
Aug 5, 2026
Merged

ENG-10800: Update XY stars count on the marketing pages#6843
Alek99 merged 1 commit into
mainfrom
carlos/update-stars-count

Conversation

@carlosabadia

@carlosabadia carlosabadia commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Review in cubic

@carlosabadia
carlosabadia requested a review from a team as a code owner August 4, 2026 15:31
@carlosabadia carlosabadia added the skip-changelog For doc/internal changes label Aug 4, 2026
@chatgpt-codex-connector

Copy link
Copy Markdown

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

@linear-code

linear-code Bot commented Aug 4, 2026

Copy link
Copy Markdown

ENG-10800

@greptile-apps

greptile-apps Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

Updates the marketing navbar to show XY's current GitHub star count and centralizes the XY repository URL and count alongside other shared constants.

  • Adds shared constants for the XY GitHub URL and star count.
  • Adds a formatter that renders counts such as 28,000 and 1,400 as “28K” and “1.4K.”
  • Uses the shared values in the marketing open-source repository list.

Confidence Score: 4/5

The PR appears safe to merge, with the non-blocking concern that the newly introduced star-count formatting behavior lacks focused test coverage.

The current constants render as intended, and no blocking runtime failure is established; the remaining issue is that future count changes can alter rounding or abbreviation behavior without automated detection.

Files Needing Attention: packages/reflex-site-shared/src/reflex_site_shared/views/marketing_navbar.py

Important Files Changed

Filename Overview
packages/reflex-site-shared/src/reflex_site_shared/constants.py Adds fixed XY GitHub URL and star-count constants for reuse by marketing views.
packages/reflex-site-shared/src/reflex_site_shared/views/marketing_navbar.py Replaces hardcoded repository metadata with shared constants and introduces an abbreviation helper, but leaves its rounding behavior without unit coverage.

Reviews (1): Last reviewed commit: "ENG-10800: Update XY stars count on the ..." | Re-trigger Greptile

@codspeed-hq

codspeed-hq Bot commented Aug 4, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 26 untouched benchmarks
⏩ 8 skipped benchmarks1


Comparing carlos/update-stars-count (e4d1f20) with main (a348aea)

Open in CodSpeed

Footnotes

  1. 8 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Tip: cubic could auto-approve low-risk PRs like this, if it thinks it's safe to merge. Learn more

Re-trigger cubic

@Alek99
Alek99 merged commit 61daf41 into main Aug 5, 2026
109 checks passed
@Alek99
Alek99 deleted the carlos/update-stars-count branch August 5, 2026 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-changelog For doc/internal changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants