Skip to content

fix: force C locale for lscpu - #6847

Merged
masenf merged 2 commits into
reflex-dev:mainfrom
benedikt-bartscher:pin-lscpu-locale
Aug 4, 2026
Merged

fix: force C locale for lscpu#6847
masenf merged 2 commits into
reflex-dev:mainfrom
benedikt-bartscher:pin-lscpu-locale

Conversation

@benedikt-bartscher

@benedikt-bartscher benedikt-bartscher commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Review in cubic

@benedikt-bartscher
benedikt-bartscher requested a review from a team as a code owner August 4, 2026 20:20
@chatgpt-codex-connector

Copy link
Copy Markdown

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

@greptile-apps

greptile-apps Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

The PR forces lscpu to run under the C locale so its field names remain compatible with the existing English-key parser.

  • Prefixes the Linux CPU-information command with LC_ALL=C.
  • Documents why locale normalization is required.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains.

Important Files Changed

Filename Overview
reflex/utils/telemetry.py Correctly applies a command-scoped C locale through the existing shell-based command helper, preserving reliable parsing of localized lscpu output.

Reviews (2): Last reviewed commit: "Merge branch 'main' into pin-lscpu-local..." | Re-trigger Greptile

@codspeed-hq

codspeed-hq Bot commented Aug 4, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 26 untouched benchmarks
⏩ 8 skipped benchmarks1


Comparing benedikt-bartscher:pin-lscpu-locale (96c8952) with main (b95c6dc)

Open in CodSpeed

Footnotes

  1. 8 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Tip: cubic could auto-approve low-risk PRs like this, if it thinks it's safe to merge. Learn more

Re-trigger cubic

@masenf masenf added the skip-changelog For doc/internal changes label Aug 4, 2026

@masenf masenf left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not caring about changelog entry for this; but i applied skip-changelog before refreshing from main so it didn't pick it up.

thanks for the fixup

@masenf
masenf merged commit 0520cd2 into reflex-dev:main Aug 4, 2026
107 of 109 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-changelog For doc/internal changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants