Enable CodSpeed continuous performance measurement#2
Closed
codspeed-hq[bot] wants to merge 2 commits into
Closed
Conversation
Author
CodSpeed setup failedThe CodSpeed setup is complete and correct: the workflow runs end to end and all 22 benchmarks pass in simulation mode on GitHub Actions (commit 681092e, run 28996846329). However, the results upload is rejected with HTTP 403 because the 'reflex-dev' organization is not subscribed to CodSpeed and 'reviz' is a private repository. This is an account/billing restriction that cannot be fixed by code or workflow changes. To finish, an org admin must subscribe the organization at https://app.codspeed.io/settings/organizations/reflex-dev. Once subscribed, re-run the CodSpeed workflow and it will post the CodSpeed report comment on the PR. |
FarhanAliRaza
added a commit
that referenced
this pull request
Jul 15, 2026
- Legend now (re)freezes options and swatch scaling via _attach() when added to an axes, so a legend constructed against one axes but attached to another picks up the host's dpi/rcParams (review #1). - Legend.__init__ warns on handles/labels length mismatch and on handles without a legend entry instead of dropping them silently (review #4). - JS tracks every legend box (not just the primary) so _resize refreshes max-height on extra legends too (review #2). - JS line swatch uses ?? so an explicit lw=0 draws nothing instead of falling back to 1.5px (review #3). - Drop unreachable return in _best_legend_loc (review #5).
FarhanAliRaza
added a commit
that referenced
this pull request
Jul 15, 2026
* Improve pyplot legend and dash parity * Fix extra legend rendering regressions * Address review: legend attach recompute, resize tracking, lw=0 swatch - Legend now (re)freezes options and swatch scaling via _attach() when added to an axes, so a legend constructed against one axes but attached to another picks up the host's dpi/rcParams (review #1). - Legend.__init__ warns on handles/labels length mismatch and on handles without a legend entry instead of dropping them silently (review #4). - JS tracks every legend box (not just the primary) so _resize refreshes max-height on extra legends too (review #2). - JS line swatch uses ?? so an explicit lw=0 draws nothing instead of falling back to 1.5px (review #3). - Drop unreachable return in _best_legend_loc (review #5). --------- Co-authored-by: Alek <alek@reflex.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This repository already contained the scaffolding for CodSpeed continuous performance measurement. This PR validates that setup end to end and corrects the CodSpeed badge so it resolves to this repository.
What was verified
benchmarks/test_codspeed_kernels.py): 22 CodSpeed benchmarks covering the native Rust compute core (zone maps, f32 encoding, M4 decimation, 2D binning, histograms, range scans) and the end-to-end figure → wire-payload path (line, scatter, area, bar, heatmap, layered composition, density memory reports).cargo build --release), installed the package withpytest-codspeed, confirmed the native backend is active (kernels.BACKEND == "native"), and executed all 22 benchmarks locally via:.github/workflows/codspeed.yml): usesCodSpeedHQ/action@v4insimulationmode with OIDC authentication (id-token: write), builds the native core so benchmarks measure the real Rust kernels, and runs onubuntu-latest. It passes the repository's ownscripts/verify_ci_workflow.pygate.What changed
Alek99/charts-exptoreflex-dev/revizso it points at this repository's CodSpeed dashboard.Next steps
mainand on pull requests, tracking the native compute kernels and payload build path.