Skip to content

Update dependencies to address security vulnerabilities - #428

Merged
masenf merged 5 commits into
mainfrom
masenf/update-deps
Aug 4, 2026
Merged

Update dependencies to address security vulnerabilities#428
masenf merged 5 commits into
mainfrom
masenf/update-deps

Conversation

@masenf

@masenf masenf commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Review in cubic

Summary by CodeRabbit

  • Chores

    • Updated application dependencies and development tooling.
    • Added improved class name handling for more consistent styling.
    • Pinned the PostCSS version to improve build consistency.
  • Bug Fixes

    • Improved documentation route handling by normalizing trailing slashes for cleaner navigation and prerendered pages.
    • Enhanced documentation validation diagnostics for startup failures, nested routes, accessibility checks, and runtime errors.

@coderabbitai

coderabbitai Bot commented Aug 4, 2026

Copy link
Copy Markdown

Review Change Stack

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 2026c3dd-3b93-4159-a7f3-33445b3ce29f

📥 Commits

Reviewing files that changed from the base of the PR and between e5de357 and dcbc9dd.

📒 Files selected for processing (3)
  • .github/workflows/docs.yml
  • docs/app/tests/test_prerender.py
  • docs/app/xy_docs/prerender.py
🚧 Files skipped from review as they are similar to previous changes (2)
  • docs/app/xy_docs/prerender.py
  • .github/workflows/docs.yml

📝 Walkthrough

Walkthrough

The PR updates dependency constraints, normalizes documentation prerender routes, and adds staged diagnostics to production documentation checks. The workflow preserves exit statuses and reports server state when validation fails.

Changes

Documentation build and validation

Layer / File(s) Summary
Manifest dependency updates
package.json, docs/app/reflex.lock/package.json
Adds or updates the postcss override and application dependencies. The application manifest adds clsx and tailwind-merge.
Prerender route normalization
docs/app/xy_docs/prerender.py, docs/app/tests/test_prerender.py
Removes trailing slashes from discovered documentation routes before prerendering. Tests validate slashless paths. Redirect routes remain unchanged.
Production check diagnostics
.github/workflows/docs.yml
Tracks validation stages, preserves the original exit status, and captures server logs, HTTP responses, and listening sockets when checks fail.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Sequence Diagram(s)

sequenceDiagram
  participant DocsWorkflow
  participant DocumentationServer
  participant ValidationChecks
  DocsWorkflow->>DocumentationServer: start production server
  DocumentationServer-->>DocsWorkflow: report readiness or early exit
  DocsWorkflow->>ValidationChecks: run route, title, accessibility, and log checks
  ValidationChecks-->>DocsWorkflow: return validation status
  DocsWorkflow->>DocumentationServer: collect logs and HTTP diagnostics on failure
Loading
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the primary dependency updates, which address security vulnerabilities.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch masenf/update-deps

Comment @coderabbitai help to get the list of available commands.

@greptile-apps

greptile-apps Bot commented Aug 4, 2026

Copy link
Copy Markdown

Greptile Summary

This PR updates Python and JavaScript dependencies to address security advisories while improving production documentation prerendering and CI diagnostics.

  • Refreshes application, documentation, and development-tool lockfiles.
  • Normalizes documentation prerender routes by removing trailing slashes.
  • Expands production documentation checks with staged diagnostics, nested-route validation, accessibility checks, and runtime-error scanning.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains.

Important Files Changed

Filename Overview
.github/workflows/docs.yml Adds failure-stage tracking and best-effort diagnostic output while preserving the production server’s original exit status.
docs/app/xy_docs/prerender.py Normalizes generated documentation and redirect prerender paths by removing trailing slashes while preserving the root route.
docs/app/tests/test_prerender.py Updates prerender configuration expectations to cover normalized nested documentation routes.
package.json Updates JavaScript build tooling and adds a PostCSS override, with resolved versions recorded in the lockfile.
docs/app/reflex.lock/package.json Refreshes generated Reflex frontend dependencies and pins the remediated PostCSS version.
package-lock.json Regenerates the root npm dependency graph for the updated security and tooling versions.
uv.lock Refreshes the root Python dependency lockfile with remediated package versions.
docs/app/uv.lock Refreshes the documentation application’s Python dependency resolution.

Reviews (5): Last reviewed commit: "address PR feedback" | Re-trigger Greptile

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 4 files

Tip: cubic used a learning from your PR history. Let your coding agent read cubic learnings directly with the cubic MCP.

Fix all with cubic | Re-trigger cubic

Comment thread package.json
@codspeed-hq

codspeed-hq Bot commented Aug 4, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 109 untouched benchmarks
⏩ 2 skipped benchmarks1


Comparing masenf/update-deps (dcbc9dd) with main (99eda6d)

Open in CodSpeed

Footnotes

  1. 2 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@Alek99
Alek99 self-requested a review August 4, 2026 19:14
Alek99
Alek99 previously approved these changes Aug 4, 2026

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.github/workflows/docs.yml:
- Around line 190-193: Update the nested documentation request in the curl
invocation to replace --fail with --fail-with-body and use --silent together
with --show-error. Preserve the existing timeout, URL, and output settings so
HTTP failure response bodies and curl error details remain available.
🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 2901d400-b8cd-4e2f-8054-9b1fdb57bb79

📥 Commits

Reviewing files that changed from the base of the PR and between 84f956a and 3816134.

📒 Files selected for processing (1)
  • .github/workflows/docs.yml

Comment thread .github/workflows/docs.yml

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 1 file (changes from recent commits).

Tip: Review your code locally with the cubic CLI to iterate faster.

Fix all with cubic | Re-trigger cubic

Comment thread .github/workflows/docs.yml Outdated
React-router 7.18.x does not strip trailing slash from configured prerender
routes, so we do that ourselves now to keep pre-rendering functional.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@docs/app/xy_docs/prerender.py`:
- Around line 74-78: Update the route construction in the prerender flow to
apply trailing-slash normalization only to routes returned by discover_docs,
while appending DOCS_REDIRECTS unchanged. Preserve the root route "/" rather
than allowing rstrip("/") to produce an empty string, and retain the expected
original redirect paths and normalized documentation paths.
🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: e93bf453-46fb-43ad-8cf6-0fe89b943a6d

📥 Commits

Reviewing files that changed from the base of the PR and between 3816134 and e5de357.

📒 Files selected for processing (1)
  • docs/app/xy_docs/prerender.py

Comment thread docs/app/xy_docs/prerender.py Outdated

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 1 file (changes from recent commits).

Tip: Review your code locally with the cubic CLI to iterate faster.

Fix all with cubic | Re-trigger cubic

Comment thread docs/app/xy_docs/prerender.py Outdated
Comment thread docs/app/xy_docs/prerender.py Outdated
@masenf
masenf merged commit d21b7bb into main Aug 4, 2026
30 checks passed
masenf added a commit that referenced this pull request Aug 4, 2026
The dependency bumps in #428 landed from a branch that was behind main, so
these ten diagnostics never appeared on that PR and now trip every branch
built on top of it.

reflex_xy/component.py: spell the event-trigger annotations as
`Annotated[rx.EventHandler, <args spec>]` instead of the shorthand
`rx.EventHandler[<args spec>]`. The two are the same object — reflex's
`EventHandler.__class_getitem__` returns exactly this Annotated form and its
trigger discovery reads the spec back out of `__metadata__` — but only the
shorthand is a runtime-only DSL: `EventHandler` is not a generic class, so
subscripting it is invalid in a type expression. All seven triggers still
resolve with the same arg-spec parameter names.

xy/_validate.py: sort the rendered form of unrecognized `mark_fill` keys.
`value` is user input whose keys need not be mutually comparable, so
`mark_fill({1: ..., "mode": ...})` raised a bare `TypeError` out of `sorted`
instead of naming the unknown key. Closed grammars are specified to raise
`ValueError` (spec/api/styling.md), so this makes the implementation match.

xy/pyplot/_axes.py: drop the now-redundant `cast` around `np.ma.asarray`,
which the newer numpy stubs already type as `MaskedArray`.

Verified against the interpreter CI resolves (3.12 / numpy 2.5.1):
`ty check python tests/typing_pep561_consumer.py` is clean.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants