Skip to content

Implementation of RFC0002#36

Merged
zdne merged 7 commits intorefractproject:masterfrom
kylef:kylef/rfc-0002
Aug 6, 2015
Merged

Implementation of RFC0002#36
zdne merged 7 commits intorefractproject:masterfrom
kylef:kylef/rfc-0002

Conversation

@kylef
Copy link
Copy Markdown
Member

@kylef kylef commented Aug 3, 2015

Tasks

@kylef
Copy link
Copy Markdown
Member Author

kylef commented Aug 5, 2015

This pull request is ready to review, would appreciate if @smizell and @zdne could give a 👍 or 👎.

Comment thread namespaces/api-description-namespace.md Outdated
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The added sentence may need refactoring a bit.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

from a expanding the any parent is illegible.

@smizell
Copy link
Copy Markdown
Contributor

smizell commented Aug 5, 2015

@kylef looks good to me. Would want Z's thoughts too.

@zdne
Copy link
Copy Markdown
Member

zdne commented Aug 6, 2015

@kylef @smizell Looks great, merging. 👍

zdne added a commit that referenced this pull request Aug 6, 2015
@zdne zdne merged commit a1b1bab into refractproject:master Aug 6, 2015
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was renamed below but not here.

@kylef kylef deleted the kylef/rfc-0002 branch August 6, 2015 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants