-
Notifications
You must be signed in to change notification settings - Fork 117
[feat] Support *:<partition name> name pattern in the list of valid systems
#1253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
92bbaf6
adding the option to specify *:<partition name> as a list of system
mboisson cca7530
Deleted extra blank line
mboisson 32a487d
Rewritten to avoid generic_partition_name being used before assignment
mboisson 6444559
Refactored to cover all cases
mboisson 831c7ea
addressing suggested changes
mboisson 75ea398
generalized supports_system to support more formats
mboisson 77db99a
fixed missing parenthesis
mboisson b677611
adding forgotten variant *:*
mboisson 80d3c72
fixing buggy over-generalization
mboisson b4fbdc4
streamlined the logic and ensured all tests pass
mboisson fe7283d
addressing most of Vasilio's comments
mboisson 7e1a215
Enforce stricter rules for the system names in valid_systems
d59940c
Revert "Enforce stricter rules for the system names in valid_systems"
99f2843
Merge branch 'master' into valid_systems_star
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.