Skip to content

Conversation

@teojgo
Copy link
Contributor

@teojgo teojgo commented Apr 9, 2020

  • Ignore the BrokenPipeError which is caused when
    the logging.Handler tries to emit to a closed stream.

Fixes #1201

* Ignore the `BrokenPipeError` which is caused when
  the `logging.Handler` tries to `emit` to a closed stream.
@teojgo teojgo added this to the ReFrame sprint 20.05 milestone Apr 9, 2020
@teojgo teojgo requested review from ekouts and vkarak April 9, 2020 15:11
@teojgo teojgo self-assigned this Apr 9, 2020
Copy link
Contributor

@vkarak vkarak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vkarak vkarak changed the title [bugfix] Ignore error when piping output to inexistent program [bugfix] Do not crash in case of broken pipe errors Apr 9, 2020
@codecov-io
Copy link

Codecov Report

Merging #1257 into master will decrease coverage by 0.32%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1257      +/-   ##
==========================================
- Coverage   91.42%   91.10%   -0.33%     
==========================================
  Files          84       84              
  Lines       12401    12000     -401     
==========================================
- Hits        11337    10932     -405     
- Misses       1064     1068       +4     
Impacted Files Coverage Δ
reframe/core/logging.py 83.76% <50.00%> (-0.88%) ⬇️
reframe/core/modules.py 60.66% <0.00%> (-1.93%) ⬇️
reframe/core/deferrable.py 92.94% <0.00%> (-1.79%) ⬇️
reframe/core/systems.py 87.96% <0.00%> (-1.71%) ⬇️
unittests/test_launchers.py 92.72% <0.00%> (-1.48%) ⬇️
unittests/test_environments.py 72.07% <0.00%> (-1.22%) ⬇️
reframe/core/environments.py 88.28% <0.00%> (-1.09%) ⬇️
reframe/core/schedulers/__init__.py 94.73% <0.00%> (-0.75%) ⬇️
reframe/core/exceptions.py 85.07% <0.00%> (-0.75%) ⬇️
reframe/core/runtime.py 88.96% <0.00%> (-0.74%) ⬇️
... and 29 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 35dfbed...c6263fd. Read the comment docs.

@vkarak vkarak merged commit cf09f72 into reframe-hpc:master Apr 9, 2020
@teojgo teojgo deleted the bugfix/broken_pipe_error branch May 12, 2020 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ReFrame crashes if its output is piped to an inexistent program

3 participants