Skip to content

[bugfix] Do not crash in case of broken pipe errors #1257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 9, 2020
Merged

[bugfix] Do not crash in case of broken pipe errors #1257

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
00da25c
Ignore error when piping output to inexistent program
Apr 9, 2020
c6263fd
Merge branch 'master' into bugfix/broken_pipe_error
Apr 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions reframe/core/logging.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,24 @@ def set_handler_level(hdlr, level):
logging.Handler.setLevel = set_handler_level


# Here we monkeypatch the `handleError` method of `logging.Handler` in
# order to ignore `BrokenPipeError` exceptions while keeping the default
# behavior for all the other types of exceptions.

def handleError(func):
def ignore_brokenpipe(hdlr, l):
exc_type, *_ = sys.exc_info()
if exc_type == BrokenPipeError:
pass
else:
func(hdlr, l)

return ignore_brokenpipe


logging.Handler.handleError = handleError(logging.Handler.handleError)


class MultiFileHandler(logging.FileHandler):
'''A file handler that allows writing on different log files based on
information from the log record.
Expand Down