[bugfix] More robust completion check for the Torque scheduler #1279
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @victorusu, Thank you for updating! Cheers! There are no PEP8 issues in this Pull Request!Do see the ReFrame Coding Style Guide Comment last updated at 2020-04-28 11:57:54 UTC |
victorusu
force-pushed
the
bugfix/torque_job_completion
branch
from
47916f7 to
ba281b0
Compare
vkarak
requested changes
Apr 24, 2020
Contributor
vkarak
left a comment
vkarak
left a comment
There was a problem hiding this comment.
I just have a minor formatting comment.
Contributor
|
@jenkins-cscs retry daint |
…fix/torque_job_completion
vkarak
reviewed
Apr 27, 2020
vkarak
requested changes
Apr 27, 2020
Contributor
vkarak
left a comment
vkarak
left a comment
There was a problem hiding this comment.
CI is failing everywhere.
…fix/torque_job_completion
vkarak
approved these changes
Apr 28, 2020
Contributor
|
@victorusu There is only a PEP8 issue remaining for this. |
vkarak
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added the code proposed by @ZQyou to the torque scheduler. @ZQyou can you please check if it works for you?
Fixes #1238