Skip to content

[bugfix] More robust completion check for the Torque scheduler #1279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 28, 2020
Merged

[bugfix] More robust completion check for the Torque scheduler #1279

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
ba281b0
Add check for out/err files for torque scheduler
victorusu Apr 23, 2020
5dcf3c4
Fix the unittest
victorusu Apr 23, 2020
9f65c89
Merge branch 'master' of https://github.com/eth-cscs/reframe into bug…
victorusu Apr 27, 2020
f7b9e49
Address PR comments
victorusu Apr 27, 2020
37cc6d2
Merge branch 'master' of https://github.com/eth-cscs/reframe into bug…
victorusu Apr 28, 2020
38d6716
Merge branch 'master' into bugfix/torque_job_completion
Apr 28, 2020
0d9cef0
Fix PEP8 issues
Apr 28, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion reframe/core/schedulers/torque.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
#

import re
import os
from datetime import datetime

import reframe.utility.os_ext as os_ext
Expand Down Expand Up @@ -92,4 +93,7 @@ def finished(self, job):
raise JobError('maximum pending time exceeded',
jobid=job.jobid)

return job.state == 'COMPLETED'
stdout = os.path.join(job.workdir, job.stdout)
stderr = os.path.join(job.workdir, job.stderr)
done = os.path.exists(stdout) and os.path.exists(stderr)
return job.state == 'COMPLETED' and done