Skip to content

Conversation

@vkarak
Copy link
Contributor

@vkarak vkarak commented Aug 30, 2020

I'm using --disable-hook as a command line option, which can be chained, for consistency with the rest of the options.

This PR also changes the output in detailed listing to the following:

- OpenCLCheck:
    Dependencies:
      <none>

    Description:
      OpenCLCheck

    Environment modules:
      craype-accel-nvidia60

    Location:
      /users/karakasv/Devel/reframe/cscs-checks/prgenv/opencl_check.py

    Maintainers:
      TM, SK

    Node allocation:
      standard (1 task(s))

    Pipeline hooks:
      pre_compile: setflags, cdt2006_pgi_workaround

    Tags:
      production, craype

    Valid environments:
      PrgEnv-cray, PrgEnv-pgi

    Valid systems:
      daint:gpu, dom:gpu, tiger:gpu

Short listing is also slightly changed (no indentation and path is quoted):

- OpenCLCheck (found in '/users/karakasv/Devel/reframe/cscs-checks/prgenv/opencl_check.py')

Fixes #1273.

Still todo:

  • Update the documentation.

Note: This PR needs to be merged after #1461.

@vkarak vkarak added this to the ReFrame sprint 20.12 milestone Aug 30, 2020
@vkarak vkarak requested review from ekouts and victorusu August 30, 2020 12:03
@vkarak vkarak self-assigned this Aug 30, 2020
@vkarak vkarak marked this pull request as draft August 30, 2020 12:03
@vkarak vkarak force-pushed the feat/pipeline-hooks-cmdline branch from e8f24f9 to 98eb1ca Compare August 30, 2020 12:04
@codecov-commenter
Copy link

codecov-commenter commented Aug 30, 2020

Codecov Report

Merging #1462 into master will decrease coverage by 0.01%.
The diff coverage is 91.04%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1462      +/-   ##
==========================================
- Coverage   91.70%   91.69%   -0.02%     
==========================================
  Files          82       82              
  Lines       12802    12852      +50     
==========================================
+ Hits        11740    11784      +44     
- Misses       1062     1068       +6     
Impacted Files Coverage Δ
reframe/frontend/cli.py 79.36% <86.66%> (-0.08%) ⬇️
unittests/test_pipeline.py 94.00% <91.66%> (-0.09%) ⬇️
reframe/core/meta.py 96.96% <100.00%> (+0.19%) ⬆️
reframe/core/pipeline.py 92.80% <100.00%> (+0.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc8bcbe...f3adc10. Read the comment docs.

Also:

- Move the `--disable-hook` option to run options
- Remove pyyaml from `requirements.txt`
@vkarak vkarak marked this pull request as ready for review August 31, 2020 11:25
@teojgo teojgo self-requested a review September 2, 2020 13:38
@vkarak vkarak merged commit 0bcff43 into reframe-hpc:master Sep 2, 2020
@vkarak vkarak deleted the feat/pipeline-hooks-cmdline branch September 2, 2020 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Control pipeline hooks from the command line

4 participants