Skip to content

[bugfix] Print current environment and partition correctly even if a test fails before the setup #1506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 6, 2020
Merged

[bugfix] Print current environment and partition correctly even if a test fails before the setup #1506

merged 4 commits into from
Oct 6, 2020

Conversation

@rsarm
Copy link
Contributor

@rsarm rsarm commented Oct 5, 2020

Fixes #1502

@rsarm rsarm requested review from ekouts and vkarak October 5, 2020 08:03
@rsarm rsarm self-assigned this Oct 5, 2020
vkarak
vkarak requested changes Oct 5, 2020
View reviewed changes
@vkarak vkarak added this to the ReFrame sprint 20.14 milestone Oct 5, 2020
@codecov-commenter
Copy link

codecov-commenter commented Oct 5, 2020 •
edited
Loading

Codecov Report

Merging #1506 into master will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1506      +/-   ##
==========================================
- Coverage   91.72%   91.72%   -0.01%     
==========================================
  Files          83       83              
  Lines       13029    13027       -2     
==========================================
- Hits        11951    11949       -2     
  Misses       1078     1078
Impacted Files Coverage Δ
reframe/frontend/statistics.py 95.45% <100.00%> (-0.06%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 068dccb...86f1944. Read the comment docs.

vkarak
vkarak approved these changes Oct 6, 2020
View reviewed changes
Copy link
Contributor

@vkarak vkarak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vkarak vkarak changed the title [bugfix] use env and partition of testcase for json report [bugfix] Print current environment and partition correctly even if a test fails before the setup Oct 6, 2020
@vkarak vkarak merged commit 84ce07d into reframe-hpc:master Oct 6, 2020
@rsarm rsarm deleted the bugfix/json-env-part branch March 10, 2021 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vkarak vkarak vkarak approved these changes

@ekouts ekouts ekouts approved these changes

Assignees

@rsarm rsarm

Labels

bugfix prio: normal

Projects

None yet

Milestone

ReFrame sprint 20.14

Development

Successfully merging this pull request may close these issues.

Wrong rerun message when a test fails before the setup phase

4 participants

@rsarm @codecov-commenter @vkarak @ekouts