Skip to content

[bugfix] Print current environment and partition correctly even if a test fails before the setup #1506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 6, 2020
Merged

[bugfix] Print current environment and partition correctly even if a test fails before the setup #1506

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f1eac39
use env and partition of testcase for json report
rsarm Oct 5, 2020
e95305e
fix comments
rsarm Oct 5, 2020
86f1944
Reorder some statements
Oct 6, 2020
d58668a
Merge branch 'master' into bugfix/json-env-part
Oct 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions reframe/frontend/statistics.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,15 +105,15 @@ def json(self, force=False):
'time_setup': t.duration('setup'),
'time_total': t.duration('total')
}
partition = check.current_partition
environ = check.current_environ
if partition:
entry['system'] = partition.fullname
entry['scheduler'] = partition.scheduler.registered_name

if environ:
entry['environment'] = environ.name

# We take partition and environment from the test case and not
# from the check, since if the test fails before `setup()`,
# these are not set inside the check.
partition = t.testcase.partition
environ = t.testcase.environ
entry['system'] = partition.fullname
entry['scheduler'] = partition.scheduler.registered_name
entry['environment'] = environ.name
if check.job:
entry['jobid'] = check.job.jobid
entry['job_stderr'] = check.stderr.evaluate()
Expand Down