Skip to content

[bugfix] Fix bug when patchlevel in environment modules version is not an integer #1540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 20, 2020
Merged

[bugfix] Fix bug when patchlevel in environment modules version is not an integer #1540

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
170d505
Fix bug when bugfix version is not an integer
jonathanfrawley Oct 16, 2020
a265abc
Merge branch 'master' into master
Oct 20, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions reframe/core/modules.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -433,7 +433,7 @@ def __init__(self):

version = version_match.group(1)
try:
ver_major, ver_minor, *_ = [int(v) for v in version.split('.')]
ver_major, ver_minor = [int(v) for v in version.split('.')[:2]]
except ValueError:
raise ConfigError(
'could not parse TMod version string: ' + version) from None
Expand Down Expand Up @@ -572,7 +572,7 @@ def __init__(self):

version = version_match.group(1)
try:
ver_major, ver_minor, *_ = [int(v) for v in version.split('.')]
ver_major, ver_minor = [int(v) for v in version.split('.')[:2]]
except ValueError:
raise ConfigError(
'could not parse TMod31 version string: ' + version) from None
Expand Down Expand Up @@ -639,7 +639,7 @@ def __init__(self):

version = version_match.group(1)
try:
ver_major, ver_minor, *_ = [int(v) for v in version.split('.')]
ver_major, ver_minor = [int(v) for v in version.split('.')[:2]]
except ValueError:
raise ConfigError(
'could not parse TMod4 version string: ' + version) from None
Expand Down