Skip to content

Conversation

@vkarak
Copy link
Contributor

@vkarak vkarak commented Feb 16, 2021

This PR allows users to log arbitrary attributes of the run job associated with the currently executing test by using the %(check_job_ATTR)s log format specifier. For example, users can log the node list that the job has run on by specifying %(check_job_nodelist)s.

Fixes #1729.

Vasileios Karakasis added 2 commits February 16, 2021 23:18
Also:

- Improve the way check attributes are retrieved
@vkarak vkarak added this to the ReFrame 3.4.2 milestone Feb 16, 2021
@vkarak vkarak requested review from ekouts and rsarm February 16, 2021 22:44
@vkarak vkarak self-assigned this Feb 16, 2021
Copy link
Contributor

@ekouts ekouts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@teojgo teojgo self-requested a review February 17, 2021 10:07
@codecov-io
Copy link

Codecov Report

Merging #1788 (25e3f77) into master (0883ee3) will increase coverage by 0.03%.
The diff coverage is 90.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1788      +/-   ##
==========================================
+ Coverage   87.36%   87.40%   +0.03%     
==========================================
  Files          47       47              
  Lines        7765     7780      +15     
==========================================
+ Hits         6784     6800      +16     
+ Misses        981      980       -1     
Impacted Files Coverage Δ
reframe/core/pipeline.py 92.16% <ø> (ø)
reframe/core/containers.py 97.64% <50.00%> (-2.36%) ⬇️
reframe/core/logging.py 84.52% <100.00%> (+0.13%) ⬆️
reframe/utility/__init__.py 91.91% <100.00%> (+0.12%) ⬆️
reframe/core/schedulers/slurm.py 52.71% <0.00%> (+0.27%) ⬆️
reframe/core/schedulers/__init__.py 98.34% <0.00%> (+0.55%) ⬆️
reframe/core/schedulers/local.py 96.63% <0.00%> (+0.84%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0883ee3...25e3f77. Read the comment docs.

@vkarak vkarak merged commit f6c2782 into reframe-hpc:master Feb 17, 2021
@vkarak vkarak deleted the feat/log-job-attributes branch February 17, 2021 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow to log easily the job's nodelist in performance log

4 participants