Skip to content

Conversation

@teojgo
Copy link
Contributor

@teojgo teojgo commented Mar 9, 2021

Fixes #1836

@vkarak
Copy link
Contributor

vkarak commented Mar 9, 2021

Is this indeed the minimal? I.e., if I remove one those, the build will fail? In the Spack package we have only those and it seems to work:

https://github.com/spack/spack/blob/3b1b51e90de380fa9524121f95df989b00eeb6a8/var/spack/repos/builtin/packages/reframe/package.py#L66-L68

@vkarak vkarak added this to the ReFrame sprint 21.03.1 milestone Mar 9, 2021
@teojgo
Copy link
Contributor Author

teojgo commented Mar 9, 2021

Is this indeed the minimal? I.e., if I remove one those, the build will fail? In the Spack package we have only those and it seems to work:

https://github.com/spack/spack/blob/3b1b51e90de380fa9524121f95df989b00eeb6a8/var/spack/repos/builtin/packages/reframe/package.py#L66-L68

Well performing pip install sphinx brings almost all the above with it.

@codecov-io
Copy link

Codecov Report

Merging #1847 (bd316bc) into master (a3d0b0c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1847   +/-   ##
=======================================
  Coverage   87.61%   87.61%           
=======================================
  Files          49       49           
  Lines        8136     8136           
=======================================
  Hits         7128     7128           
  Misses       1008     1008           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a3d0b0c...bd316bc. Read the comment docs.

@vkarak vkarak changed the title [feat] Minimize and update doc requirements [feat] Minimize the list of doc requirements Mar 10, 2021
@vkarak vkarak merged commit 796e67b into reframe-hpc:master Mar 10, 2021
@teojgo teojgo deleted the feat/requirements_doc branch May 21, 2021 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Minimize the list of required dependencies in docs/requirements.txt

3 participants